IBuilder.updateBuild() needs to be asynchronous

Reported by Julian Edwards on 2010-07-29
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Julian Edwards

Bug Description

The buildd-manager calls this method at the beginning of scanning each builder that is currently building something. It's currently synchronous, which means that it blocks everything else in the buildd-manager until it completes.

It would benefit from being converted to using Twisted Deffereds similar to the dispatch mechanism. Initially this can be a simple case of extending the RecordingSlave that the manager uses to wrap the normal (synchronous) slave class but ultimately we should ditch RecordingSlave and make the existing one entirely asynchronous.

Related branches

lp:~bac/launchpad/rollback-11801
Rejected for merging into lp:launchpad
Brad Crittenden: Approve (code) on 2010-10-27
Changed in soyuz:
assignee: nobody → Julian Edwards (julian-edwards)
status: Triaged → In Progress
Brad Crittenden (bac) on 2010-10-27
tags: added: bad-commit-11801
Changed in soyuz:
milestone: none → 10.11
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11815 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11815) by a commit, but not testable.

tags: added: qa-untestable
removed: qa-ok
Robert Collins (lifeless) wrote :

Needs a deployment to the buildd-manager machine to fix-release this.

Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r11815 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11815) by a commit, but not testable.

tags: added: buildd-scalability
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers