Launchpad itself

LaunchpadObjectFactory returns naked objects

Bug #609982 reported by Abel Deuring
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

add security proxies to the object returned by the methods makeBranchMergeProposal(), makeCodeReviewVoteReference(), makeBinaryPackagePublishingHistory()makeDistributionSourcePackage() of LaunchpadObjectfactory

see also bug 607236

See original description

Related branches

lp:~adeuring/launchpad/security-guarded-test-object-factory-3
Rejected for merging into lp:launchpad
Henning Eggers (community): Abstain (code)
Aaron Bentley: Pending requested
Diff: 176 lines (+37/-19)
4 files modified
lib/lp/bugs/doc/bug-heat.txt (+7/-4)
lib/lp/bugs/tests/test_bugheat.py (+21/-8)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+3/-2)
lib/lp/testing/factory.py (+6/-5)
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Abel Deuring (adeuring) → nobody
status: In Progress → Triaged
description: updated
summary: add security proxies to the object returned by the methods
- makeBranchMergeProposal(), makeCodeReviewVoteReference(),
- makeBinaryPackagePublishingHistory()makeDistributionSourcePackage() of
- LaunchpadObjectfactory
Robert Collins (lifeless)
tags: added: tech-debt
summary: - add security proxies to the object returned by the methods
+ LaunchpadObjectFactory returns naked objects
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers