Launchpad itself

TestDistroSourcePackageReleaseFiles requires unproxied distroseries objects

Bug #608240 reported by Abel Deuring
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

The branch lp:~adeuring/launchpad/security-guarded-test-object-factory-1 lets LaunchpadObjectFactory.makeDistroSeries() return security proxied objects.

The tests in TestDistroSourcePackageReleaseFiles will pass only when the security proxy is removed in the setUp() method of the class. I find this a bit scary in a browser test

See original description

Related branches

~cjwatson/launchpad:test-dspr-files-proxy
Jürgen Gmach: Approve
Diff: 30 lines (+1/-9)
1 file modified
lib/lp/soyuz/browser/tests/test_distrosourcepackagerelease.py (+1/-9)
Julian Edwards (julian-edwards)
tags: added: tech-debt
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
Colin Watson (cjwatson)
summary: - TestDistroSourcePackageReleaseFiles requires unproxied distrroseries
+ TestDistroSourcePackageReleaseFiles requires unproxied distroseries
objects
description: updated
Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.