Launchpad itself

ensure that methods of LaunchpadObjectFactory do not return objects without a security proxy

Bug #607236 reported by Abel Deuring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Abel Deuring
Launchpad itself 10.08

Bug Description

we still have numerous methods in LaunchpadObjectFactory which return unproxied objects.

Related branches

lp:~adeuring/launchpad/security-guarded-test-object-factory-1
Jeroen T. Vermeulen (community): Approve (code)
Diff: 852 lines (+251/-48)
20 files modified
lib/lp/code/browser/tests/test_branchlisting.py (+4/-2)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+12/-5)
lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+4/-1)
lib/lp/code/model/tests/test_branch.py (+4/-1)
lib/lp/code/model/tests/test_linkedbranch.py (+7/-2)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+5/-2)
lib/lp/registry/browser/tests/distroseries-views.txt (+1/-1)
lib/lp/registry/browser/tests/milestone-views.txt (+5/-1)
lib/lp/registry/browser/tests/productseries-views.txt (+6/-2)
lib/lp/registry/stories/webservice/xx-project-registry.txt (+4/-2)
lib/lp/registry/tests/test_distroseries.py (+15/-6)
lib/lp/registry/tests/test_sourcepackage.py (+9/-2)
lib/lp/soyuz/browser/tests/test_distrosourcepackagerelease.py (+7/-1)
lib/lp/soyuz/browser/tests/test_sourcepackagerelease.py (+11/-5)
lib/lp/soyuz/tests/test_publishing.py (+9/-3)
lib/lp/testing/factory.py (+82/-7)
lib/lp/testing/tests/test_factory.py (+50/-0)
lib/lp/translations/browser/tests/test_breadcrumbs.py (+3/-1)
lib/lp/translations/doc/translations-export-to-branch.txt (+5/-1)
lib/lp/translations/stories/buildfarm/xx-build-summary.txt (+8/-3)
Revision history for this message
Abel Deuring (adeuring) wrote :

a proper fix is to guard the results of LaunchpadObjectFactory so that only objects having a security proxy and simply Python objects can "leave" the factory

Revision history for this message
Gary Poster (gary) wrote :

Abel, you tried to talk to me about this at the Epic and I was not as helpful as I should have been. Please let me know if you'd like to talk about this now.

Changed in launchpad-foundations:
importance: Undecided → High
Abel Deuring (adeuring)
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11208 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11208>.

Changed in launchpad-foundations:
milestone: none → 10.08
tags: added: qa-needstesting
Stuart Bishop (stub)
tags: added: qa-untestable
removed: qa-needstesting
Diogo Matsubara (matsubara)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.