BinaryPackageBuildSet.getBuildsByArchIds orders inconsistently

[William Grant]

BinaryPackageBuildSet.getBuildsByArchIds orders by BuildQueue.lastscore DESC, BinaryPackageBuild.id, but Builder._findBuildCandidate orders by BuildQueue.lastscore DESC, BuildQueue.id. This means that retries will show up earlier in the visible build listings than their actual position in the queue (since their BuildQueue.id will be later).

[Julian Edwards (julian-edwards)]

What "visible build listings" do you mean?

[William Grant (wgrant)]

The distroseries build queue is the example that I saw. This morning, when filtered for NEEDSBUILD and ia64 (https://edge.launchpad.net/ubuntu/maverick/+builds?build_text=&build_state=pending&arch_tag=ia64), it was showing a whole lot of KDE builds at the head of the queue. They had been retried, so were in reality queued *behind* the rest.