IProjectSet.search() has unused untested optional arguments

[James Henstridge]

Both IProductSet.search() and IProjectSet.search() include optional arguments to constrain the search to products (resp. projects) that use rosetta, malone, bazaar, etc.

These arguments can be used via the productset and projectset views by URL hacking. For example:
    https://launchpad.net/products?text=gnome&bazaar=1

However there is nothing in the page templates that would let a user do this (I think they used to be visible a long time ago). One of the following should be done:

 * expose the checkboxes in the page templates, and add tests
 * remove support for these constraints from the view classes and database classes
 * remove support for these constraints from the view classes, but leave them in the DB classes and add tests.

[Jeroen T. Vermeulen (jtv)]

For IProductSet, those arguments are also completely untested.

The entire test suite calls the method only in one place (bugtask-adding-pages.txt, from bugalsoaffects.py) and only the first parameter is used. Breaking that method only breaks that test, and all tests pass if the method is made to break whenever any of the other arguments is given.

Also, the rosetta argument produces invalid SQL: see bug 1415.

[Barry Warsaw (barry)]

Assigning to me. Time box to 2 hours for now.

[Curtis Hovey (sinzui)]

I want to remove the arguments. I do not think they are used. I doubt we will give 3 years has passed.

[Curtis Hovey (sinzui)]

Remove the arguments.

[j.c.sackett (jcsackett)]

The PersonSet.search() method is gone, and there doesn't appear to be a method on PersonSet that has those parameters any longer.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12010 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12010>.