Launchpad itself

distroseries +packaging and +needs-packaging could cache

Bug #599818 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned
Launchpad itself 10.07

Bug Description

Recent schema changes make data retrieval for +packaging and +needs-packagin much faster, but. packages are added/removed from +packaging and +needs-packaging about 10 times a day. The queries rarely return *new* information. A 30 minute public cache will help the pages display quicker.

Related branches

lp:~sinzui/launchpad/registry-tales-2
Leonard Richardson (community): Approve
Diff: 97 lines (+22/-9)
4 files modified
lib/lp/registry/browser/tests/milestone-views.txt (+15/-4)
lib/lp/registry/templates/distroseries-needs-packaging.pt (+2/-1)
lib/lp/registry/templates/distroseries-packaging.pt (+2/-1)
lib/lp/registry/templates/milestone-index.pt (+3/-3)
lp:~sinzui/launchpad/registry-cache-3
Edwin Grubbs (community): Approve
Diff: 283 lines (+142/-54)
6 files modified
lib/lp/registry/browser/tests/milestone-views.txt (+1/-50)
lib/lp/registry/browser/tests/test_milestone.py (+64/-0)
lib/lp/registry/browser/tests/test_packaging.py (+35/-0)
lib/lp/registry/templates/distroseries-needs-packaging.pt (+3/-2)
lib/lp/registry/templates/distroseries-packaging.pt (+3/-2)
lib/lp/testing/memcache.py (+36/-0)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11077 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11077>.

tags: added: qa-needstesting
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote :

The cache rule that were applied by the first branch are ineffective. Each entry in the listing is cached, but the view is still calling the expensive query. A change to an entry usually means it is linked to an upstream, and thus disappears from the listing. The entire table should be cached; move the cache instruction before the repeat.

Changed in launchpad-registry:
status: Fix Committed → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-bad
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.