pre-requisite branch link in a merge proposal should be to the proposal for the prerequisite
Bug #598328 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Similar to bug 456418, which is about showing info about the prerequisite; this one is more focused -please show the merge proposal for the prerequisite branch rather/as well as the branch itself.
e.g. in
Status:
Needs review
Proposed branch: lp:~amanica/bzr/find_bzrdirs-ignore-branches-with-missing-repos
Merge into: lp:bzr
Prerequisite: lp:~amanica/bzr/find_bzrdirs-ignore-PermissionDenied-dirs
Diff against target: 64 lines (+24/-1) 3 files modified
The prerequisite link there could be to the mp for it.
(This implies that a prerequisite branch that is not proposed for merging would prevent creation of an MP).
Revision history for this message
| Tim Penhey (thumper) wrote | #1 |
| tags: | added: code-review |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Robert Collins (lifeless) wrote Re: [Bug 598328] Re: pre-requisite branch link in a merge proposal should be to the proposal for the prerequisite | #2 |
| Changed in launchpad: | |
| importance: | Medium → Low |
To post a comment you must log in.
If we were going to link to the code review rather than the branch, we should change the text. All through Launchpad a link that looks like a branch url links to the branch. To have it here linking to a code review would be confusing.