help links should be sprites

Bug #595907 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Brad Crittenden

Bug Description

I see we are adding help links that are neither test friendly, or reuse the icon *already loaded* in the sprite file.

This is bad markup:

    <a target="help" href="/+help/driver.html" class="icon">
      <img src="/@@/maybe" alt="help" /></a>

Better markup is:

    <a target="help" href="/+help/driver.html"
      class="sprite maybe"><span class="invisible-link">Driver help</span></a>

Related branches

Brad Crittenden (bac)
Changed in launchpad-web:
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Even better markup:

    <a target="help" href="/+help/driver.html"
      class="sprite maybe">&nbsp;<span class="invisible-link">Driver help</span></a>

This is the zero-width problem. My fix to the formatters was to ensure there is always a space in the link.

ObjectImageDisplayAPI.boolean
    <span class="sprite %(icon)s">&nbsp;<span class="invisible-link">%(icon)s</span></span>

Note that we always want to place an &nbsp; before the invisible-link element, or in the anchor if it is being left empty.

Curtis Hovey (sinzui)
Changed in launchpad-web:
milestone: 10.06 → 10.07
Curtis Hovey (sinzui)
Changed in launchpad-web:
milestone: 10.07 → 10.06
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
tags: added: qa-needstesting
removed: qa-ok
Ursula Junque (ursinha)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-web:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers