commit message not seen inline during needs-review->wip->needs-review transition
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
While reviewing a merge proposal for bzr[1]
Vincent added a comment (search for "Hmm, just re-read the bug comments" on the page) and changed the state of the mp from "Needs Review" to "Work in Progress".
At this point, I fixed the comment and pushed a revision to the branch (see " 5293. By Parth Malwankar on 2010-06-15: cleaner handling of lock_url display").
A few more comments were added on the page following which I put the state to "Needs Review" again. Interestingly, my commit does not show up inline (in a grey box) with the comments and this causes confusion to the reviewer. The reviewer doesn't know that a commit is done towards his comment without going through the diff.
[1] https:/
summary: |
- commit not seen inline during needs-review->wip->needs-review transition + commit message not seen inline during needs-review->wip->needs-review + transition |
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: code-review confusing-ui |