A bug's can_expire attribute is confusing

[Brad Figg]

My example is bug #203251. This bug reached a stage where can_expire was set. If just a comment is added to the bug, can_expire is not unset. If the status of the bug is changed from "Incomplete" to "Triaged" then can_expire *is* unset. However, as soon as the status is set back to "Incomplete" can_expire is set again.

[Brian Murray (brian-murray)]

bug = launchpad.bugs[203251]
In [3]: bug.can_expire
Out[3]: True
In [4]: bug.date_last_updated
Out[4]: datetime.datetime(2010, 6, 15, 21, 53, 48, 256877, tzinfo=TimeZone(0))

I wonder how often the can_expire attribute of a bug report is updated.

[Deryck Hodge (deryck)]

Setting this back to New to make sure I take a look today.

[Deryck Hodge (deryck)]

I've had a look now. can_expire is a wrapper around findExpirableBugTasks, which only looks at date_last_updated and not date_last_message. We should extend the query in findExpirableBugTasks to consider date_last_message.

While I think this is an easy bug to fix, I'm hesitant to tag it trivial, as I have this theory that ultimately no malone bug is trivial. But this is an easy one, definitely.

[Brian Murray (brian-murray)]

date_last_updated is not the issue. In comment 1 you can see that date_last_updated is recent and less than 60 days old.

[Brian Murray (brian-murray)]

Some documentation, at least in lib/lp/bugs/doc/bugtask-expiration.txt, about can_expire indicates that it only should indicate if the bug *may* expire.

"IBug specifies two properties related to bug expiration. can_expire
tells you whether one or more of the bug's bug tasks may be expired, if
the bug doesn't get any more activity."

[Brian Murray (brian-murray)]

So if can_expire really means may expire than the documentation should be updated to reflect that. However, the following test passes and I'm unsure why.

    # Add a comment to the bug report and see if it can still expire
    >>> from lp.bugs.tests.bug import create_old_bug
    >>> ubuntu_bugtask2 = create_old_bug('expirable_distro', 351, ubuntu)
    >>> ubuntu_bugtask2.bug.can_expire
    True
    >>> from lp.testing.factory import LaunchpadObjectFactory
    >>> factory = LaunchpadObjectFactory()
    >>> factory.makeBugComment(bug=ubuntu_bugtask2.bug)
    <Message at...
    >>> ubuntu_bugtask2.bug.can_expire
    False

[Ursula Junque (ursinha)]

Fixed in stable r11108 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11108>.