Don't use time.sleep(10) in the Soyuz SFTP tests

Bug #586695 reported by Steve Kowalik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Julian Edwards

Bug Description

In lib/lp/poppy/tests/test_poppy.py, in the function waitForClose() for the SFTP service, there is a time.sleep(10) call. This is horrible, and should be changed to something more elegant.

Related branches

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Twisted has twisted.internet.task.Clock, I wonder if there's something similar for Zope?

Changed in soyuz:
status: New → Triaged
importance: Undecided → High
tags: added: tech-debt
Revision history for this message
Julian Edwards (julian-edwards) wrote :

(where you can use Clock.advance() in tests to wind the clock forward instantaneously)

Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Julian Edwards (julian-edwards)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
milestone: none → 11.03
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.