Builder edit page times out or hangs

Bug #583905 reported by Julian Edwards
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Julian Edwards

Bug Description

Sometimes submitting the Builder:+edit page mysteriously times out with no OOPS generated. It turns out that when submitting the form, the code at LaunchpadEditFormView.updateContextFromData() tries to make a snapshot of the object by iterating over all of its properties, so that it can tell event listeners which fields got changed.

One of those properties, is_available, makes a call to a slave to get its status. This is obviously Not Good when done in a webapp request as there are some firewalls in the way.

There's a couple of options to fix it:

1. use the doNotSnapshot() method in the interface for the property
2. pass notify_modified=False to updateContextFromData()

Related branches

Changed in soyuz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Julian Edwards (julian-edwards)
description: updated
tags: added: soyuz-core timeout
Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
Changed in soyuz:
milestone: none → 10.05
status: In Progress → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Verified that we can now edit:
https://edge.launchpad.net/builders/molybdenum
setting to OK/Not OK without the timeout error.

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.