no support for reading from the git smart server protocol over HTTP

Bug #581933 reported by Soren Hansen on 2010-05-17
42
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Bazaar Git Plugin
High
Jelmer Vernooij
Launchpad itself
High
Jelmer Vernooij

Bug Description

I wanted to import a new project on Launchpad (http://launchpad.net/filecache). The code is stored on github. Github's UI is such that the URL for their repo's are shown with an http:// prefix. I asked Launchpad to import this code, which failed thusly:

   http://launchpadlibrarian.net/48592764/soren-filecache-trunk.log

I then remembered that I had another import from github which works, so I went to see how it was different. It used a git:// prefix, so I tried that instead, and it worked like a charm:

   http://launchpadlibrarian.net/48623135/soren-filecache-trunk2.log

The broken import now lives at https://code.edge.launchpad.net/~soren/filecache/trunk-fail in case you want to use it for debugging. Please either let me know when you are done with it so I can delete it, or alternatively feel free to delete it, when you've gathered whatever debug information you need.

Related branches

Soren Hansen (soren) on 2010-05-17
summary: - Import from http://github.com fail, while ones from git://github.com
+ Imports from http://github.com fail, while ones from git://github.com
work
Curtis Hovey (sinzui) on 2010-05-17
affects: launchpad → launchpad-code

That's a change in the github ui, I think.

Git imports over http have worked at some point, but apparently not at the moment...

Tim Penhey (thumper) wrote :

Actually I think this is a combination of bzr-git/dulwich that we have rolled out right now.

This has been fixed I believe, and I am landing the updated bzr-git and dulwich now (ec2 running as I type). I'll check this works on staging before asking for a cherry pick into production.

Changed in launchpad-code:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Tim Penhey (thumper)
milestone: none → 10.05
Tim Penhey (thumper) on 2010-05-31
Changed in launchpad-code:
status: In Progress → Fix Committed
Curtis Hovey (sinzui) on 2010-06-02
Changed in launchpad-code:
status: Fix Committed → Fix Released
Soren Hansen (soren) wrote :

This exact same thing just happened again:

I asked for an import of http://github.com/nova/cc.git here:

    https://code.edge.launchpad.net/~soren/novacc/trunk-fail

It failed. Note: The branch was originally named "trunk".

I then tried the same import with a git:// prefix:

    https://code.edge.launchpad.net/~soren/novacc/trunk

It succeeded. Note: This branch was originally named trunk2.

Soren Hansen (soren) wrote :

The novacc project has been renamed to nova, so the failing branch is now at

   https://code.edge.launchpad.net/~soren/nova/trunk-fail

Also, I forgot to reopen the bug with my last comment. Doing so now.

Changed in launchpad-code:
status: Fix Released → New
Aaron Bentley (abentley) on 2010-08-02
Changed in launchpad-code:
status: New → Triaged
tags: added: code-import
Jelmer Vernooij (jelmer) wrote :

This is a github-specific bug; it looks like it doesn't allow "dumb" access to the repositories over HTTP, only access using the Git smart HTTP protocol.

Dave has added support for this to Dulwich recently, but it hasn't been hooked up in bzr-git yet.

Changed in bzr-git:
status: New → Triaged
importance: Undecided → Medium
Jelmer Vernooij (jelmer) on 2011-02-23
summary: - Imports from http://github.com fail, while ones from git://github.com
- work
+ no support for git smart server protocol over HTTP
Changed in bzr-git:
importance: Medium → High
Tim Penhey (thumper) on 2011-02-24
Changed in launchpad:
assignee: Tim Penhey (thumper) → nobody
summary: - no support for git smart server protocol over HTTP
+ no support for reading from the git smart server protocol over HTTP
Jelmer Vernooij (jelmer) on 2011-09-03
Changed in bzr-git:
status: Triaged → Fix Committed
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in bzr-git:
milestone: none → 0.6.3
Jelmer Vernooij (jelmer) on 2011-09-14
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
Jelmer Vernooij (jelmer) wrote :

This works, although there was a related issue that came up - we currently don't ignore non-NotBranchErrors from probers like bzr's core does. Since the "dumb" git prober is run before the smart server prober, this means that almost all repositories that require smart protocol access fail at the moment.

Eli Zaretskii (eliz) wrote :

You mean, smart protocol access over HTTP doesn't work, yes? git:// still works, right?

On Thu, Sep 15, 2011 at 04:30:11AM -0000, Eli Zaretskii wrote:
> You mean, smart protocol access over HTTP doesn't work, yes? git://
> still works, right?
It doesn't work in all situations. My comment was also only relevant
to Launchpad, it doesn't apply to direct use of bzr-git through bzr.

Cheers,

Jelmer

William Grant (wgrant) on 2011-09-15
Changed in launchpad:
status: Fix Committed → Fix Released
Jelmer Vernooij (jelmer) on 2011-11-01
Changed in bzr-git:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers