Launchpad itself

verifyBuildRequest is broken

Bug #581899 reported by Aaron Bentley
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Aaron Bentley
Launchpad itself 10.05

Bug Description

RecipeBuildBehavior.verifyBuildRequest refers to the non-existant attribute SourcePackageRecipeBuild.is_virtual, instead of SourcePackageRecipeBuild.virtual. This only breaks when the builder is not a virtual builder, so we haven't seen it often in testing.

Related branches

lp:~abentley/launchpad/fix-recipebuilder
Paul Hummer (community): Approve (code)
Diff: 139 lines (+40/-7)
5 files modified
lib/lp/code/interfaces/sourcepackagerecipebuild.py (+3/-1)
lib/lp/code/model/recipebuilder.py (+1/-1)
lib/lp/code/model/sourcepackagerecipebuild.py (+9/-3)
lib/lp/code/model/tests/test_recipebuilder.py (+23/-0)
lib/lp/testing/factory.py (+4/-2)
Aaron Bentley (abentley)
Changed in launchpad-code:
status: Confirmed → In Progress
assignee: nobody → Aaron Bentley (abentley)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10917 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10917>

Changed in launchpad-code:
milestone: none → 10.05
status: In Progress → Fix Committed
tags: added: qa-needstesting
Aaron Bentley (abentley)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.