10.10 milestone name corrupted in JS: 10.1

[Matthew Revell]

Steps to reproduce:

1. In a series of a Launchpad sub-project (e.g. malone) create a milestone named 10.10.
2. Notice the error message "Could not retrieve milestone 10.10" in the Milestones and Releases table.
3. Refresh and the error becomes a link to a new 10.1 milestone, rather than 10.10.

See screen shot.

[Curtis Hovey (sinzui)]

Looks like the trailing '0' is lost between ajax and the form. The milestone is created as 10.1, which causes the error. The user can then rename the milestone. It is possible for this problem to create another error is the x.1 milestone already exists.

[Curtis Hovey (sinzui)]

The problem is type conversion. Code names are strings, "10.10" is a string, but JS thinks it is a float, so it drops the 0.
maybe milestoneoverlay.js can do the string concatenation hack to ensure version is alwaysa string
    code_name: data['field.code_name'][0],
should be
    code_name: '' + data['field.code_name'][0],

[Barry Warsaw (barry)]

It's kind of icky, but I guess we'll just have to skip X.10 version numbers. I suppose this affects all X.Y0 versions.

[Marc Deslauriers (mdeslaur)]

FYI, I believe I worked around this issue by adding quotes when I entered the version number.

[Barry Warsaw (barry)]

On Oct 09, 2013, at 03:53 PM, Marc Deslauriers wrote:

>FYI, I believe I worked around this issue by adding quotes when I
>entered the version number.

Indeed!

You'll get an error saying `Couldn't retrieve milestone "1.10"` but if you
refresh the page, the milestone sans quotes will be there just fine.

Thanks for the workaround.

[Curtis Hovey (sinzui)]

I had contemplated an alternate workaround on the backend. The script
will append "~~" and the backend always strips ~~.

[William Grant (wgrant)]

Or you can just middle-click the "Create milestone" link to navigate to the non-AJAX form, which isn't affected by the JS bug.

[William Grant (wgrant)]

The misbehaviour is caused by lazr.restful's SimpleFieldMarshaller.marshall_from_request. It attempts to decode the form value as JSON, using it as a string only if the parsing fails. We probably want to avoid that decoding if we know we're looking for a string and not some other kind of object.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r17815 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17815>.

[Colin Watson (cjwatson)]

This had to be rolled back a couple of times due to breaking other bits of JS and has now been reverted from trunk, so we'll need to fix those up and QA more thoroughly before re-landing this.