Person merge code does not take into account inactive and proposed memberships

Bug #58138 reported by Diogo Matsubara
34
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Unassigned

Bug Description

Steps to reproduce (using sample data):
1. Log in as Sample Person;
2. Open http://launchpad.dev/people/+requestmerge
3. Fill in 'Duplicated Account': spiv; Note that spiv is an proposed member in
ubuntu-team
4. Click Submit;
5. Open http://launchpad.dev/people/ubuntu-team/+members and you'll see
Andrew Bennetts (spiv-merged) as one of the proposed members.

A merged person shouldn't appear in that list.
Also note that if you access
http://launchpad.dev/people/ubuntu-team/+editproposedmembers spiv-merged
appears in that list and you can even approve his membership request.

Related branches

Revision history for this message
James Henstridge (jamesh) wrote :

Note that due to the (person, team) unique key for team memberships, the merge code should handle the case where both people being merged have team membership records.

Stuart Bishop (stub)
Changed in launchpad:
assignee: stub → nobody
description: updated
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Medium → Low
status: Confirmed → Triaged
Revision history for this message
Alan Bell (alanbell) wrote :

this breaks python-launchpadlib code that itterates through team members doing stuff, it hits a person that does not exist and gets a 404 error and falls over.

Curtis Hovey (sinzui)
tags: added: merge-deactivate
removed: registry
Curtis Hovey (sinzui)
tags: added: teams users
Revision history for this message
Robert Collins (lifeless) wrote :

SPM reporting in the dupe, that (due to this bug), they have a pending invitation from a suspended user for the ~canonical-losas team.
Wanting to decline said invite.
click on the action butan, get an OOPS:
OOPS-6f070765c6fb24d1bb6435a0e4ef64b9

Changed in launchpad:
importance: Low → Critical
tags: added: oops
tags: added: tech-debt
summary: - Person merge code should take into account inactive and proposed
+ Person merge code does not take into account inactive and proposed
memberships
Steve McInerney (spm)
tags: added: canonical-losa-lp
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers