+needs-packaging lists duplicates

[Curtis Hovey]

I viewied the first 200 items listed in https://launchpad.net/ubuntu/maverick/+needs-packaging and +packaging and I saw several duplicates. The duplication is not obvious since Ubuntu has so many packages. It is more ovious when looking at a Debian series: https://launchpad.net/debian/squeeze/+packaging (there are 205 packages, but the listing contains 544).

[Curtis Hovey (sinzui)]

+needs-packaging may not have duplicates. You can reload and watch the order change. The hack to speed up page loads causes many packages to have the same rank, and the order without that rank is random. There should be a second sort by sourcepackagename.name.

[Curtis Hovey (sinzui)]

The duplication is caused by the number of releases in the series. eg:
    https://launchpad.net/debian/squeeze/+source/gnome-screensaver
lists seven releases and it happens to be listed 7 times in +packaging.

The DistroSeries._current_sourcepackage_joins_and_conditions() uses
    spph.status IN %(active_status)s
hoping to limit cause a 1-1 condition between spn -> spr -> spph
Launchpad does not have the superceeded/deleted information for Debian, so
there are multiples. Ubuntu could have multiples too as something is being built.

Our options are:
    * tweak this painful SQL
    * Ignore the Ubuntu issue because it is self-correcting, but limit the feature to Ubuntu
    * Consider using DSPCache

I favour the last item because It make be faster.

[Curtis Hovey (sinzui)]

Hi Edwin.

I have a branch that will fix the /perceived/ Ubuntu issue. It will not really prevent duplicates. The query needs a major restructuring to do that. Since you are working on the timeout issue. I think you should undertake fixing the query to return distincts. I think this is still a separate issue that may deserve a separate branch. I think the best time to fix this is after the model is refactored to make the query easier.

[Ursula Junque (ursinha)]

Fixed in stable r10883 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10883>

[Curtis Hovey (sinzui)]

I suspect Edwin's branch may have fixed this. We will wait until we can do staging testing to determin if this is fixed, or must be deferred to 10.07

[Curtis Hovey (sinzui)]

I am still seeing duplicates in debian. I know this is because Debian packages are not marked as superceeded or deleted by Launchpad. We need to decide if we are going to make packaging listings exclusive to Ubuntu or to make the queries comensate for bad data.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11248 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11248>.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11266 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11266>.

[Curtis Hovey (sinzui)]

Fixed released in launchpad-project 10.08.