ec2test barfs if the ssh-agent keys are stored in the wrong order

[Māris Fogels]

The "ec2 test" and "ec2 land" commands crash if the ssh-agent has its keys stored in order such that the first public key listed is not the default identity on the current host. The ec2 instance dies when it tries to download the sourcecode from launchpad onto the new instance using that non-default key. A traceback showing this is attached.

For example, it will crash if my agent stores the keys in the following order, with a remote server's public key coming first:

mars@local $ ssh-add -l
ff:ff:ff:ff:ff mars@remote
ff:ff:ff:ff:ff mars@remote2
dd:dd:dd:dd mars@launchpad # this is the key I use to access Launchpad

ec2test will incorrectly select the first public key ('mars@remote'), copy that to the ec2 instance, then try and download the sourcecode from Launchpad using it. The key mismatch causes Launchpad to reject the login, then everything crashes.

The correct behaviour is to specify or intelligently find the key or identity that the ec2 instance should use to download files from Launchpad.

As a workaround you might be able to take all of the keys in your ssh-agent and add them to Launchpad.

[Ursula Junque (ursinha)]

Fixed in stable r10842 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10842>

[Māris Fogels (mars)]

I'm removing the QA landing flags. The landing was just to add an XXX, not a fix. The bug is still open.