~vcs-imports team need privileges review

[Brad Crittenden]

We want to open import reviews up to community members by adding them to the ~vcs-imports team. It appears the team currently has some extra privileges they should not. A thorough review needs to be done and the permissions set to be no more generous than necessary.

MaxB reports these current capabilities:

Privileges are:

lp.registry.browser.product: ~vcs-imports members can set the owner and license_reviewed flag of projects when registering a new project.

canonical.launchpad.security:

IProductSeries launchpad.Admin <--- weird!
IBazaarApplication launchpad.Admin
ICodeImport launchpad.Edit
ICodeImportJobSet launchpad.View
ICodeImportJobWorkflow launchpad.Edit
ICodeImportMachine launchpad.Edit
IBranch that is a code import launchpad.Edit

[Max Bowsher (maxb)]

It has been hypothesized that the original purpose of IProductSeries launchpad.Admin might be to allow ~vcs-imports people to designate a newly created vcs import as the series development focus. This might not be sane, and should perhaps be handled through some other team. Perhaps ~launchpad-chr.

[Tim Penhey (thumper)]

On Thu, 06 May 2010 10:25:42 you wrote:
> It has been hypothesized that the original purpose of IProductSeries
> launchpad.Admin might be to allow ~vcs-imports people to designate a
> newly created vcs import as the series development focus. This might not
> be sane, and should perhaps be handled through some other team. Perhaps
> ~launchpad-chr.

No, originally import details were always connected to a product series.

Historical rubbish.

[Ursula Junque (ursinha)]

Fixed in stable r10861 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10861>

[Max Bowsher (maxb)]

Remaining issues:

* thumper's branch didn't update the docstring of canonical.launchpad.security.EditCodeImportMachine, which now lies.

* thumper's branch didn't address the special access given to ~vcs-imports in lp.registry.browser.product.

[Ursula Junque (ursinha)]

Fixed in stable r10914 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10914>