~vcs-imports team need privileges review
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
High
|
Tim Penhey | ||
Bug Description
We want to open import reviews up to community members by adding them to the ~vcs-imports team. It appears the team currently has some extra privileges they should not. A thorough review needs to be done and the permissions set to be no more generous than necessary.
MaxB reports these current capabilities:
Privileges are:
lp.registry.
canonical.
IProductSeries launchpad.Admin <--- weird!
IBazaarApplication launchpad.Admin
ICodeImport launchpad.Edit
ICodeImportJobSet launchpad.View
ICodeImportJobW
ICodeImportMachine launchpad.Edit
IBranch that is a code import launchpad.Edit
Related branches
- Michael Hudson-Doyle: Approve on 2010-05-24
-
Diff: 72 lines (+1/-33)3 files modifiedlib/canonical/launchpad/security.py (+1/-1)
lib/lp/registry/browser/product.py (+0/-26)
lib/lp/registry/browser/tests/project-add-views.txt (+0/-6)
| Max Bowsher (maxb) wrote : | #1 |
On Thu, 06 May 2010 10:25:42 you wrote:
> It has been hypothesized that the original purpose of IProductSeries
> launchpad.Admin might be to allow ~vcs-imports people to designate a
> newly created vcs import as the series development focus. This might not
> be sane, and should perhaps be handled through some other team. Perhaps
> ~launchpad-chr.
No, originally import details were always connected to a product series.
Historical rubbish.
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: tech-debt |
Fixed in stable r10861 <http://
| Changed in launchpad-code: | |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 10.05 |
| status: | Triaged → Fix Committed |
| tags: | added: qa-needstesting |
| Max Bowsher (maxb) wrote : | #4 |
Remaining issues:
* thumper's branch didn't update the docstring of canonical.
* thumper's branch didn't address the special access given to ~vcs-imports in lp.registry.
| Ursula Junque (ursinha) wrote : | #5 |
Fixed in stable r10914 <http://
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
It has been hypothesized that the original purpose of IProductSeries launchpad.Admin might be to allow ~vcs-imports people to designate a newly created vcs import as the series development focus. This might not be sane, and should perhaps be handled through some other team. Perhaps ~launchpad-chr.