Launchpad itself

Person.__repr__ causes an oops masking the real error because displayname is unicode

Bug #575976 reported by Diogo Matsubara
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Curtis Hovey
Launchpad itself 10.05

Bug Description

As seen on OOPS-1582EB1587 a UnicodeEncodeError was raised while GET'ing the +reviewaccount page for a person and the person display name contains non-ascii characters.

Related branches

lp:~sinzui/launchpad/oopsless-repr
Eleanor Berger (community): Approve (code)
Diff: 169 lines (+68/-10)
6 files modified
lib/canonical/launchpad/database/account.py (+2/-1)
lib/canonical/launchpad/tests/test_account.py (+17/-0)
lib/lp/registry/model/distribution.py (+4/-3)
lib/lp/registry/model/person.py (+2/-2)
lib/lp/registry/tests/test_distribution.py (+28/-4)
lib/lp/registry/tests/test_person.py (+15/-0)
Revision history for this message
Curtis Hovey (sinzui) wrote :

The oops was created *after* the canonical_urldata_iterator raised its own error because henninge hacked the URL to non-existant person. The error message wanted to tell henninge to be a good boy, but the NoCanonicalUrl uses the __repr__ of the object, which for many launchpad objects, will contain unicode.

summary: - +reviewaccount page oopses with a UnicodeEncodeError if the display name
- contains non-ascii characters
+ Person.__repr__ causes an oops masking the real error because
+ displayname is unicode
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

Sweet apparently this is a Python 2.5 issue that we need to hack around if we want this fixed now.

Revision history for this message
Curtis Hovey (sinzui) wrote :

We can use canonical.launchpad.helpers.backslashreplace(self.displayname) to make the name safe.

This affects the following models:
Account
Distribution
Person

Account is under discussion for removal. Account by the way is what henninge was try to hack, but Person got in the way, or more to the point, did nto exist to get in the way for the URL to work.

tags: added: trivial
Changed in launchpad-registry:
milestone: none → series-future
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Would this fix also fix bug 191945 ? It looks like it would given Barry's suggestion on 191945, so I'm in favor to dupe this one against 191945 or the other way around.
Do you agree Curtis?

Revision history for this message
Curtis Hovey (sinzui) wrote :

I could if we added email address to the list. Earch __repr__ needs a hack based on our understanding the field permits unicode.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Sorry. I did not finish my thought. We do not own email address anymore, It is SSO I think, and I am note sure if our implementation is to be removed. Account is a table that has been decided must be removed. It does no harm in fixing it even if it gets removed.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: series-future → 10.05
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10854 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10854>

tags: added: qa-needstesting
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.