Oops on negative batch parameter
Bug #574159 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
lazr.batchnavigator |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
We got an oops in Translations yesterday: OOPS-1582C923
This user had hacked up a URL to set the batching parameter to -300, which breaks result-set slicing for the page.
It would be nice to have this kind of invalid parameter value caught right up front, just like the values greater than 300, so we don't get oopses on the individual Launchpad applications.
Related branches
lp:~jtv/lazr.batchnavigator/bug-574159
- Abel Deuring (community): Approve (code)
- Barry Warsaw: Pending (code) requested
-
Diff: 101 lines (+55/-14)2 files modifiedsrc/lazr/batchnavigator/README.txt (+21/-0)
src/lazr/batchnavigator/_batchnavigator.py (+34/-14)
lp:~jtv/launchpad/bug-574159
- Gary Poster (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedversions.cfg (+1/-1)
affects: | launchpad → launchpad-foundations |
tags: | added: ui |
Changed in lazr.batchnavigator: | |
status: | Triaged → Fix Committed |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
Changed in launchpad-foundations: | |
status: | Triaged → In Progress |
milestone: | none → 10.05 |
Changed in launchpad-foundations: | |
status: | In Progress → Fix Committed |
Changed in lazr.batchnavigator: | |
status: | Fix Committed → Fix Released |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Triaging as high because of OOPS policy