Oops on negative batch parameter

Bug #574159 reported by Jeroen T. Vermeulen on 2010-05-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Jeroen T. Vermeulen
lazr.batchnavigator
High
Jeroen T. Vermeulen

Bug Description

We got an oops in Translations yesterday: OOPS-1582C923

This user had hacked up a URL to set the batching parameter to -300, which breaks result-set slicing for the page.

It would be nice to have this kind of invalid parameter value caught right up front, just like the values greater than 300, so we don't get oopses on the individual Launchpad applications.

Related branches

Curtis Hovey (sinzui) on 2010-05-03
affects: launchpad → launchpad-foundations
Gary Poster (gary) wrote :

Triaging as high because of OOPS policy

Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → High
Changed in lazr.batchnavigator:
importance: Undecided → High
status: New → Triaged
Jeroen T. Vermeulen (jtv) wrote :

Attaching the branch I wrote for this yesterday. Normally this would've happened automatically, but the branch scanner seems to be held up.

tags: added: ui
Changed in lazr.batchnavigator:
status: Triaged → Fix Committed
assignee: nobody → Jeroen T. Vermeulen (jtv)
Gary Poster (gary) wrote :

Current status: jtv is making a release of lazr.batchnavigator and then preparing a branch of LP to use it. Assigning him the Foundations task as well, since the integration is the Foundations part.

Changed in launchpad-foundations:
assignee: nobody → Jeroen T. Vermeulen (jtv)
Changed in launchpad-foundations:
status: Triaged → In Progress
milestone: none → 10.05
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in lazr.batchnavigator:
status: Fix Committed → Fix Released
Diogo Matsubara (matsubara) wrote :

I have just QA'ed this one with the following:
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=100, work as expected with a batch of 100 results
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=350, work as expected with an error page "Invalid Batch Size"
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=-300, work as expected ignoring the negative batch parameter, returning the default 50 results

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui) on 2010-06-02
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers