tests depend on precise values factory returns
Bug #572163 reported by
Michael Hudson-Doyle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Curtis Hovey |
Bug Description
I changed the factory to return different values from getUniqueInteger (from where all the uniquification comes in the factory) and the following tests failed:
lp.codehosting.
lp.soyuz.
archive-
branch-karma_txt (code)
person-
xx-branch-index_txt (code)
xx-distribution
These tests should all be fixed.
Related branches
lp:~thumper/launchpad/fix-factory-ids-in-tests
- Paul Hummer (community): Approve (code)
-
Diff: 145 lines (+29/-49)2 files modifiedlib/lp/code/doc/branch-karma.txt (+3/-2)
lib/lp/code/stories/branches/xx-branch-index.txt (+26/-47)
lp:~sinzui/launchpad/robust-tests-0
- Eleanor Berger (community): Approve
-
Diff: 53 lines (+9/-6)2 files modifiedlib/lp/registry/browser/tests/person-admin-views.txt (+3/-2)
lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt (+6/-4)
Changed in soyuz: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: tech-debt |
Changed in launchpad-registry: | |
importance: | Undecided → High |
status: | New → Triaged |
milestone: | none → 10.05 |
tags: | added: trivial |
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → 10.05 |
Changed in launchpad-registry: | |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
status: | Triaged → Fix Released |
To post a comment you must log in.
lp.codehosting. scanner. tests.test_ email.TestBzrSy ncEmail. test_import_ uncommit passes when I change the default start value.
The code looks fine. Do you have the original failure email?