changelog close feature might miss some bugs

[Brian Murray]

The upload of ubuntu-netbook-default-settings version 0.7.4 did not close bug 524333 even thought it was listed in Launchpad-Bugs-Fixed. I believe this is because bug 524333 is about 'ubuntu-netbook-remix-default-settings' and not ubuntu-netbook-default-settings. However, unrds is no longer a source package (so wouldn't have bugs filed about it) but a binary package provided by unds (where the bug would be expected to be found). I think that if the Launchpad-Bugs-Fixed bug numbers include a bug with a bug task about a binary package (which allows bug filing in Launchpad) the bug task should be closed by the janitor.

I wonder how many other left over open bugs like this there are too.

Part of the changes file:

Format: 1.8
Date: Fri, 26 Feb 2010 11:04:38 +0100
Source: ubuntu-netbook-default-settings
Binary: ubuntu-netbook-default-settings ubuntu-netbook-remix-default-settings
Architecture: source
Version: 0.7.4
Distribution: lucid
Urgency: low
Maintainer: Ubuntu Mobile Developers <email address hidden>
Changed-By: Didier Roche <email address hidden>
Description:
 ubuntu-netbook-default-settings - Default settings for Ubuntu Netbook Edition
 ubuntu-netbook-remix-default-settings - Transitional package for Ubuntu Netbook default settings
Launchpad-Bugs-Fixed: 524154 524333
Changes:
 ubuntu-netbook-default-settings (0.7.4) lucid; urgency=low
 .
   [ Jordan Mantha ]
   * 20_une-gconf-default:
     Added Vlc (LP: #524333), Onboard (LP: #524154) to maximus
     exclusion list.
 .
   [ Didier Roche ]
   * debian/20_une-gconf-mandatory:
     - asked to g-s-d to not draw the background (netbook-launcher is
       already doing it)
   * debian/20_une-gconf-default:
     - added Seahorse-agent Gnome-keyring-prompt to maximus exclusion list
     - default background image is no more stretched but zoom to have the
       same default than GNOME session, and so, same cache by default

[Julian Edwards (julian-edwards)]

Brian, I'm not sure what can be done about this. Your analysis is about right, except that ubuntu-netbook-remix-default-settings is indeed a valid source package, it's just not in lucid. You're wrong in that you can file a bug on a binary package, it always resolves to the source on the bug task.

The Soyuz code right now simply hooks into the Bugs code and says "here's a bug number and a source package, please close the bugtask." Even it it were to use binary names on the package, "ubuntu-netbook-remix-default-settings" would resolve to the source on the development distro series, which is ubuntu-netbook-default-settings.

Deryck, do you have any ideas?

[Deryck Hodge (deryck)]

Unfortunately, I don't think I can help here. It's just a matter of being able to pass the correct target to bug.setStatus, which like you note seems pretty tough to work out from an ISourcePackageRelease.

[Julian Edwards (julian-edwards)]

Brian, do you have any more thoughts based on these comments?

[Launchpad Janitor (janitor)]

[Expired for Launchpad itself because there has been no activity for 60 days.]

[Brian Murray (brian-murray)]

Julian - Doesn't the distro series appear in the changelog though?

Changes:
 ubuntu-netbook-default-settings (0.7.4) lucid; urgency=low

So if you were to look up the source package for that distro series you'd get the right source package correct?

[Julian Edwards (julian-edwards)]

I'm going to triage this to low for now because I have no ideas on what can be done. It requires some careful analysis by people who know the bugs code better than I do.