Pottery needs to be better at finding out the package name
Bug #568355 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Henning Eggers | ||
Bug Description
Currently pottery looks for "GETTEXT_PACKAGE" in po/Makefile.in.in, configure.ac, configure.in. But that may just be assigned from another variable like "PACKAGE" or even "AC_PACKAGE_NAME". The latter is not assigned directly in the file but by the call to AC_INIT. Here it could be the fourth argument (tar name) or the first.
Another problem is that "DOMAIN" on po/Makevars may be assigned from another variable, too, but the current code does no further substitutions.
Pottery needs to check all these posibilities.
Related branches
lp:~henninge/launchpad/bug-568355-package-name
- Abel Deuring (community): Approve (code)
-
Diff: 402 lines (+224/-42)2 files modifiedlib/canonical/buildd/pottery/intltool.py (+72/-38)
lib/lp/translations/tests/test_pottery_detect_intltool.py (+152/-4)
| Changed in rosetta: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in rosetta: | |
| assignee: | nobody → Henning Eggers (henninge) |
| status: | Triaged → In Progress |
| milestone: | none → 10.05 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10832 <http://