Update BinaryPackageBuild to use concrete PackageBuild
Bug #567922 reported by
Michael Nelson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Nelson | ||
Bug Description
As part of the backend changes for:
https:/
the soyuz BinaryPackageBuild needs to be switched from the old build table to the new binarypackagebuild table, delegating to PackageBuild for all common package build attributes, as shown at:
http://
Once this is done and tested, we can do the same for SourcePackageRe
Related branches
lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild
- Eleanor Berger (community): Approve (code)
-
Diff: 563 lines (+261/-40)11 files modifiedlib/canonical/launchpad/interfaces/_schema_circular_imports.py (+2/-0)
lib/lp/buildmaster/browser/configure.zcml (+14/-0)
lib/lp/buildmaster/browser/packagebuild.py (+42/-0)
lib/lp/buildmaster/configure.zcml (+1/-1)
lib/lp/buildmaster/interfaces/buildbase.py (+3/-0)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+50/-20)
lib/lp/buildmaster/interfaces/packagebuild.py (+31/-6)
lib/lp/buildmaster/model/buildfarmjob.py (+30/-0)
lib/lp/buildmaster/model/packagebuild.py (+27/-0)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+11/-0)
lib/lp/buildmaster/tests/test_packagebuild.py (+50/-13)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-2
- Jeroen T. Vermeulen (community): Approve (code)
- Brad Crittenden (community): Abstain
- Jelmer Vernooij: Pending (code) requested
-
Diff: 664 lines (+293/-68) (has conflicts)11 files modifiedlib/lp/buildmaster/interfaces/buildbase.py (+10/-1)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+11/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+43/-0)
lib/lp/buildmaster/model/buildbase.py (+58/-28)
lib/lp/buildmaster/model/buildfarmjob.py (+4/-0)
lib/lp/buildmaster/model/packagebuild.py (+33/-0)
lib/lp/buildmaster/tests/test_buildbase.py (+61/-12)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+1/-0)
lib/lp/buildmaster/tests/test_packagebuild.py (+38/-12)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+2/-1)
lib/lp/soyuz/tests/test_build.py (+32/-13)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-3
- Jelmer Vernooij (community): Approve (code*)
-
Diff: 786 lines (+263/-94) (has conflicts)13 files modifiedBRANCH.TODO (+4/-0)
lib/lp/buildmaster/doc/buildfarmjob.txt (+8/-5)
lib/lp/buildmaster/interfaces/buildbase.py (+1/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+32/-0)
lib/lp/buildmaster/model/buildbase.py (+103/-57)
lib/lp/buildmaster/model/buildfarmjob.py (+9/-3)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+3/-2)
lib/lp/buildmaster/model/packagebuild.py (+53/-9)
lib/lp/buildmaster/tests/test_buildbase.py (+3/-3)
lib/lp/buildmaster/tests/test_packagebuild.py (+19/-6)
lib/lp/code/model/sourcepackagerecipebuild.py (+9/-3)
lib/lp/soyuz/model/buildpackagejob.py (+9/-4)
lib/lp/translations/model/translationtemplatesbuildjob.py (+10/-1)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild-4
- Abel Deuring (community): Approve (code)
-
Diff: 711 lines (+184/-237) (has conflicts)11 files modifiedBRANCH.TODO (+6/-0)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+40/-34)
lib/lp/buildmaster/model/buildfarmjob.py (+109/-97)
lib/lp/buildmaster/model/packagebuild.py (+8/-71)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+0/-12)
lib/lp/code/model/sourcepackagerecipebuild.py (+4/-4)
lib/lp/soyuz/interfaces/buildfarmbuildjob.py (+2/-2)
lib/lp/soyuz/model/buildpackagejob.py (+6/-6)
lib/lp/soyuz/tests/test_buildpackagejob.py (+3/-3)
lib/lp/translations/model/translationtemplatesbuildjob.py (+3/-4)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+3/-4)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-1
- Aaron Bentley (community): Approve
-
Diff: 1092 lines (+252/-243) (has conflicts)20 files modifiedlib/lp/buildmaster/doc/buildfarmjob.txt (+0/-11)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+65/-73)
lib/lp/buildmaster/interfaces/packagebuild.py (+14/-13)
lib/lp/buildmaster/model/buildfarmjob.py (+37/-23)
lib/lp/buildmaster/model/packagebuild.py (+18/-4)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+1/-4)
lib/lp/buildmaster/tests/test_packagebuild.py (+4/-0)
lib/lp/code/configure.zcml (+0/-1)
lib/lp/soyuz/configure.zcml (+0/-2)
lib/lp/soyuz/doc/build.txt (+3/-2)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+28/-11)
lib/lp/soyuz/model/binarypackagebuild.py (+56/-62)
lib/lp/soyuz/model/sourcepackagerelease.py (+12/-10)
lib/lp/soyuz/templates/build-index.pt (+1/-1)
lib/lp/soyuz/templates/builds-list.pt (+2/-2)
lib/lp/soyuz/tests/test_build.py (+7/-13)
lib/lp/soyuz/tests/test_buildpackagejob.py (+0/-4)
lib/lp/translations/configure.zcml (+1/-3)
lib/lp/translations/model/translationtemplatesbuildjob.py (+1/-1)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+2/-3)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-2
- Brad Crittenden (community): Approve (code)
-
Diff: 756 lines (+188/-86) (has conflicts)17 files modifiedlib/lp/buildmaster/interfaces/buildbase.py (+7/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+7/-0)
lib/lp/buildmaster/model/buildbase.py (+6/-5)
lib/lp/buildmaster/model/buildfarmjob.py (+1/-1)
lib/lp/buildmaster/model/packagebuild.py (+11/-4)
lib/lp/code/model/sourcepackagerecipe.py (+1/-1)
lib/lp/code/tests/test_sourcepackagerecipebuild.py (+1/-1)
lib/lp/soyuz/interfaces/binarypackagebuild.py (+2/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+48/-29)
lib/lp/soyuz/model/buildfarmbuildjob.py (+50/-0)
lib/lp/soyuz/model/buildpackagejob.py (+7/-7)
lib/lp/soyuz/model/publishing.py (+1/-1)
lib/lp/soyuz/model/sourcepackagerelease.py (+15/-8)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+11/-9)
lib/lp/soyuz/tests/test_hasbuildrecords.py (+3/-1)
lib/lp/soyuz/tests/test_publishing.py (+14/-14)
lib/lp/soyuz/tests/test_publishing_models.py (+3/-3)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-3
- Abel Deuring (community): Approve (code)
-
Diff: 768 lines (+159/-90) (has conflicts)15 files modifiedlib/canonical/launchpad/security.py (+3/-2)
lib/lp/buildmaster/model/buildbase.py (+18/-10)
lib/lp/buildmaster/model/buildfarmjob.py (+9/-1)
lib/lp/buildmaster/model/packagebuild.py (+4/-0)
lib/lp/registry/model/sourcepackage.py (+10/-7)
lib/lp/soyuz/configure.zcml (+2/-2)
lib/lp/soyuz/model/archive.py (+17/-8)
lib/lp/soyuz/model/binarypackagebuild.py (+25/-18)
lib/lp/soyuz/model/publishing.py (+16/-9)
lib/lp/soyuz/tests/test_archive.py (+12/-8)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+15/-7)
lib/lp/soyuz/tests/test_buildpackagejob.py (+4/-2)
lib/lp/soyuz/tests/test_hasbuildrecords.py (+9/-5)
lib/lp/soyuz/tests/test_publishing.py (+13/-10)
lib/lp/soyuz/tests/test_publishing_models.py (+2/-1)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-4
- Edwin Grubbs (community): Approve (code)
-
Diff: 785 lines (+163/-116) (has conflicts)21 files modifiedlib/lp/archiveuploader/nascentupload.py (+2/-2)
lib/lp/archiveuploader/nascentuploadfile.py (+4/-4)
lib/lp/buildmaster/browser/configure.zcml (+2/-1)
lib/lp/buildmaster/browser/packagebuild.py (+0/-42)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+6/-1)
lib/lp/buildmaster/model/buildfarmjob.py (+7/-0)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+24/-0)
lib/lp/soyuz/adapters/archivedependencies.py (+2/-2)
lib/lp/soyuz/doc/archive-dependencies.txt (+9/-8)
lib/lp/soyuz/doc/archive-files.txt (+1/-1)
lib/lp/soyuz/doc/archive.txt (+2/-2)
lib/lp/soyuz/doc/build-failedtoupload-workflow.txt (+4/-4)
lib/lp/soyuz/model/archive.py (+9/-6)
lib/lp/soyuz/model/binarypackagebuild.py (+33/-20)
lib/lp/soyuz/model/binarypackagerelease.py (+3/-3)
lib/lp/soyuz/model/distributionsourcepackagerelease.py (+10/-6)
lib/lp/soyuz/model/publishing.py (+6/-5)
lib/lp/soyuz/model/queue.py (+2/-2)
lib/lp/soyuz/model/sourcepackagerelease.py (+7/-5)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+28/-0)
lib/lp/soyuz/tests/test_packageupload.py (+2/-2)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-5
- Eleanor Berger (community): Approve (code)
-
Diff: 970 lines (+248/-179) (has conflicts)10 files modifiedlib/canonical/launchpad/security.py (+45/-27)
lib/lp/buildmaster/configure.zcml (+19/-12)
lib/lp/buildmaster/model/buildfarmjob.py (+5/-3)
lib/lp/buildmaster/model/packagebuild.py (+8/-2)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+38/-6)
lib/lp/buildmaster/tests/test_packagebuild.py (+43/-1)
lib/lp/soyuz/doc/binarypackagebuild.txt (+50/-104)
lib/lp/soyuz/doc/buildd-mass-retry.txt (+1/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+38/-22)
lib/lp/soyuz/stories/webservice/xx-builds.txt (+1/-1)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-6
- Eleanor Berger (community): Approve (code)
-
Diff: 787 lines (+135/-104) (has conflicts)22 files modifiedlib/lp/buildmaster/model/buildfarmjob.py (+6/-1)
lib/lp/soyuz/doc/buildd-dispatching.txt (+15/-11)
lib/lp/soyuz/doc/distroarchseries.txt (+1/-1)
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+2/-2)
lib/lp/soyuz/doc/distroseriesqueue.txt (+1/-1)
lib/lp/soyuz/doc/gina-multiple-arch.txt (+3/-3)
lib/lp/soyuz/doc/gina.txt (+8/-8)
lib/lp/soyuz/doc/initialise-from-parent.txt (+2/-2)
lib/lp/soyuz/doc/package-meta-classes.txt (+1/-1)
lib/lp/soyuz/doc/sourcepackagerelease.txt (+7/-2)
lib/lp/soyuz/model/binarypackagebuild.py (+0/-2)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+18/-18)
lib/lp/soyuz/model/buildfarmbuildjob.py (+4/-3)
lib/lp/soyuz/model/buildpackagejob.py (+23/-12)
lib/lp/soyuz/model/distributionsourcepackagerelease.py (+4/-5)
lib/lp/soyuz/model/distroarchseriesbinarypackagerelease.py (+1/-1)
lib/lp/soyuz/model/distroseriesbinarypackage.py (+1/-1)
lib/lp/soyuz/model/distroseriessourcepackagerelease.py (+8/-7)
lib/lp/soyuz/model/queue.py (+4/-4)
lib/lp/soyuz/scripts/gina/handlers.py (+16/-17)
lib/lp/soyuz/scripts/queue.py (+2/-2)
lib/lp/soyuz/tests/test_buildpackagejob.py (+8/-0)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-7
- Graham Binns (community): Approve
-
Diff: 875 lines (+141/-100) (has conflicts)33 files modifiedlib/canonical/launchpad/webapp/configure.zcml (+1/-1)
lib/canonical/launchpad/webapp/tales.py (+4/-4)
lib/lp/buildmaster/model/builder.py (+9/-3)
lib/lp/registry/browser/person.py (+4/-4)
lib/lp/registry/browser/sourcepackage.py (+1/-1)
lib/lp/registry/model/distribution.py (+2/-2)
lib/lp/registry/templates/person-macros.pt (+1/-1)
lib/lp/soyuz/browser/binarypackagerelease.py (+1/-1)
lib/lp/soyuz/browser/build.py (+3/-3)
lib/lp/soyuz/browser/configure.zcml (+1/-1)
lib/lp/soyuz/browser/distributionsourcepackagerelease.py (+2/-2)
lib/lp/soyuz/browser/publishing.py (+1/-1)
lib/lp/soyuz/model/archive.py (+4/-3)
lib/lp/soyuz/model/distributionsourcepackagerelease.py (+3/-3)
lib/lp/soyuz/model/files.py (+4/-4)
lib/lp/soyuz/model/publishing.py (+1/-1)
lib/lp/soyuz/stories/ppa/xx-copy-packages.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-ppa-files.txt (+4/-4)
lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-binarypackagerelease-index.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-build-record.txt (+17/-9)
lib/lp/soyuz/stories/soyuz/xx-private-builds.txt (+7/-6)
lib/lp/soyuz/stories/soyuz/xx-queue-pages-delayed-copies.txt (+1/-1)
lib/lp/soyuz/stories/webservice/xx-builds.txt (+27/-3)
lib/lp/soyuz/stories/webservice/xx-hasbuildrecords.txt (+6/-5)
lib/lp/soyuz/templates/build-index.pt (+18/-18)
lib/lp/soyuz/templates/build-retry.pt (+1/-1)
lib/lp/soyuz/templates/builds-list.pt (+8/-8)
lib/lp/soyuz/templates/distributionsourcepackagerelease-index.pt (+1/-1)
lib/lp/soyuz/templates/packagepublishing-details.pt (+1/-1)
lib/lp/soyuz/templates/sourcepackagepublishinghistory-listing-archive-detailed.pt (+1/-1)
lib/lp/soyuz/templates/sourcepackagepublishinghistory-listing-archive-extra.pt (+1/-1)
lib/lp/soyuz/templates/sourcepackagerelease-portlet-builds.pt (+3/-3)
lp:~michael.nelson/launchpad/567922-binarypackagebuild-new-table-8
- Graham Binns (community): Approve
-
Diff: 296 lines (+41/-31) (has conflicts)12 files modifieddatabase/schema/pending/michaeln-build-generalisation.sql (+2/-4)
lib/lp/archivepublisher/domination.py (+6/-5)
lib/lp/archiveuploader/tests/test_buildduploads.py (+2/-2)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+4/-4)
lib/lp/archiveuploader/tests/test_securityuploads.py (+5/-5)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+1/-1)
lib/lp/buildmaster/model/buildfarmjob.py (+6/-1)
lib/lp/code/interfaces/sourcepackagerecipebuild.py (+4/-0)
lib/lp/code/model/sourcepackagerecipebuild.py (+1/-0)
lib/lp/registry/doc/distroseries.txt (+1/-1)
lib/lp/registry/model/distroseries.py (+5/-4)
lib/lp/soyuz/model/buildpackagejob.py (+4/-4)
lp:~michael.nelson/launchpad/db-changes-build-generalisation-new
- Björn Tillenius (community): Approve (db)
- Stuart Bishop (community): Approve (db)
-
Diff: 736 lines (+484/-113)5 files modifieddatabase/sampledata/current-dev.sql (+112/-44)
database/sampledata/current.sql (+112/-44)
database/schema/comments.sql (+26/-17)
database/schema/patch-2207-57-0.sql (+210/-0)
database/schema/security.cfg (+24/-8)
lp:~michael.nelson/launchpad/567922-fix-ec2-failures-after-db-devel-merge
- Abel Deuring (community): Approve (code)
-
Diff: 1064 lines (+168/-141)20 files modifiedlib/lp/buildmaster/configure.zcml (+1/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+1/-1)
lib/lp/buildmaster/model/buildbase.py (+8/-7)
lib/lp/buildmaster/model/buildfarmjob.py (+1/-1)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+1/-2)
lib/lp/buildmaster/model/packagebuild.py (+3/-4)
lib/lp/buildmaster/tests/test_buildbase.py (+1/-1)
lib/lp/buildmaster/tests/test_buildqueue.py (+22/-12)
lib/lp/buildmaster/tests/test_manager.py (+4/-4)
lib/lp/soyuz/browser/tests/archive-views.txt (+6/-6)
lib/lp/soyuz/doc/build-estimated-dispatch-time.txt (+4/-4)
lib/lp/soyuz/doc/buildd-scoring.txt (+4/-2)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+62/-62)
lib/lp/soyuz/model/binarypackagebuild.py (+16/-11)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+2/-1)
lib/lp/soyuz/scripts/buildd.py (+4/-4)
lib/lp/soyuz/scripts/packagecopier.py (+4/-4)
lib/lp/soyuz/scripts/tests/test_buildd_cronscripts.py (+13/-3)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+10/-10)
lib/lp/soyuz/scripts/tests/test_populatearchive.py (+1/-1)
| summary: |
- Update BinaryPackageBuild to delegate to PackageBuild + Update BinaryPackageBuild to use concrete PackageBuild |
| Changed in soyuz: | |
| milestone: | 10.04 → 10.05 |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Michael Nelson (michael.nelson) |
| description: | updated |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r9405 <http://