Trailing slash in svn url causes import to fail

Bug #56357 reported by David Allouche
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
David Allouche

Bug Description

Bad formatting of svnrepository sometimes causes cscvs to fail with a mysterious assertion.

See: http://subversion.tigris.org/issues/show_bug.cgi?id=2119

There should be a database constraint and corresponding input validation to ensure that svnrepository urls are "canonical" by the libsvn definition.

That includes (but is probably not limited to):
* no trailing slash
* no multiple slash

This normalisation must be done at the database level (and not just in cscvs) to prevent circumvention of the unique constraint on svnrepository.

Tags: lp-code
David Allouche (ddaa)
Changed in launchpad-bazaar:
importance: Untriaged → Medium
status: Unconfirmed → Confirmed
David Allouche (ddaa)
description: updated
David Allouche (ddaa)
description: updated
David Allouche (ddaa)
Changed in launchpad-bazaar:
importance: Medium → High
Tim Penhey (thumper)
Changed in launchpad-bazaar:
assignee: nobody → ddaa
Revision history for this message
David Allouche (ddaa) wrote :

Now, the series/+source form performs the required URL normalization.

This is not ideal, as this should really be a database constraint, but this is good enough to address the visible problem. Making this bug Low importance.

Changed in launchpad-bazaar:
importance: High → Low
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Raising importance a notch, as the error message is now a bit harsh: the input form could just strip any trailing '/'.

Changed in launchpad-bazaar:
importance: Low → Medium
Revision history for this message
David Allouche (ddaa) wrote :

After all, I do not think tightening the database constraints is worth the trouble. Just fixing the input validation to quietly strip trailing '/' would be enough.

Revision history for this message
David Allouche (ddaa) wrote :

Fix up for review.

Changed in launchpad-bazaar:
status: Confirmed → In Progress
Revision history for this message
David Allouche (ddaa) wrote :

RF 4935

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
David Allouche (ddaa) wrote :

Released in 1.1.10.

Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers