Trailing slash in svn url causes import to fail

[David Allouche]

Bad formatting of svnrepository sometimes causes cscvs to fail with a mysterious assertion.

See: http://subversion.tigris.org/issues/show_bug.cgi?id=2119

There should be a database constraint and corresponding input validation to ensure that svnrepository urls are "canonical" by the libsvn definition.

That includes (but is probably not limited to):
* no trailing slash
* no multiple slash

This normalisation must be done at the database level (and not just in cscvs) to prevent circumvention of the unique constraint on svnrepository.

[David Allouche (ddaa)]

Now, the series/+source form performs the required URL normalization.

This is not ideal, as this should really be a database constraint, but this is good enough to address the visible problem. Making this bug Low importance.

[Michael Hudson-Doyle (mwhudson)]

Raising importance a notch, as the error message is now a bit harsh: the input form could just strip any trailing '/'.

[David Allouche (ddaa)]

After all, I do not think tightening the database constraints is worth the trouble. Just fixing the input validation to quietly strip trailing '/' would be enough.

[David Allouche (ddaa)]

Fix up for review.

[David Allouche (ddaa)]

RF 4935

[David Allouche (ddaa)]

Released in 1.1.10.