two notifications for review approval by single person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
affects launchpad-code
done
On my merge proposal
https:/
I received two notifications when it was approved. One read:"""
The proposal to merge lp:~lifeless/launchpad/bug-562058 into
lp:launchpad has been updated.
Status: Needs review => Approved
"""
The other read: """
Review: Approve
Looks fine, can you land this yourself? Otherwise I can of course.
The diff on this page is very odd, I wonder what happened there.
"""
Note that this isn't the same as 'I got two emails for each
notification', this is 'I was notified twice by a single person
reviewing and approving the proposal' - with the combined result that I
got four emails ;).
I realise that this is due to the split between review comment and
proposal status, but its still undesirable, in email, to be quite this
chatty.
-Rob
| Changed in launchpad-code: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Robert Collins (lifeless) wrote | #1 |
| tags: | added: email notifications |
event combining would address this