approving merge proposal by email can hit db permission error
Bug #562048 reported by
Michael Hudson-Doyle
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
As seen in https:/
This isn't biting us all the time because of the order in which things that grant you launchpad.Edit on the merge proposal are checked: it's the third line out of this condition that hits the problem:
return (user.inTeam(
Related branches
lp:~thumper/launchpad/code-email-permissions
- Michael Hudson-Doyle: Approve
-
Diff: 51 lines (+30/-0)2 files modifieddatabase/schema/security.cfg (+1/-0)
lib/lp/code/mail/tests/test_codehandler.py (+29/-0)
Changed in launchpad-code: | |
status: | Triaged → In Progress |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 10.04 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
What is this going to take to get fixed? My standard review model is to review via email, and when one of these email bounces, it doesn't even post the comment on the review. So I have to go track down what email I was reviewing (since the URL isn't included in the failure message), and then track down my original submission, and copy and paste it into the review dialog. (And then click 2-3 more times to get all the review statuses updated.)
It gets in my way about 1-2 times per day, and basically makes it so that reviewing is basically the last thing I want to be doing...