Launchpad itself

Create approver base class

Bug #561592 reported by Henning Eggers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

We have two "Approver" classes atm, TranslationBranchApprover used for uploads from branches and TranslationBuildApprover for uploads from automatic builds. Both have an "approve" method that basically does the same thing in each class.

It would be better if both approvers shared a base class with a common "approve" method while _getOrCreatePOTemplateForPath (currently just in TranslationBuildApprover) is implemented differently.

Данило Шеган (danilo)
tags: added: tech-debt
Changed in rosetta:
status: New → Triaged
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.