MP.queued_revid not set when setting queue status in API
Bug #561170 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Robert Collins | ||
Bug Description
>>> all_mps[
u'https:/
>>> all_mps[
>>> all_mps[0].queuer
<person at https:/
I think it makes sense to grab the approved revid by default when queueing.
Related branches
lp:~lifeless/launchpad/merge
- Tim Penhey (community): Approve
-
Diff: 292 lines (+95/-36)6 files modifiedlib/lp/code/configure.zcml (+0/-1)
lib/lp/code/doc/branch-merge-proposals.txt (+1/-1)
lib/lp/code/interfaces/branchmergeproposal.py (+3/-3)
lib/lp/code/model/branchmergeproposal.py (+28/-25)
lib/lp/code/model/tests/test_branchmergeproposals.py (+62/-5)
lib/lp/testing/factory.py (+1/-1)
- Canonical Launchpad Engineering: Pending requested
-
Diff: 1823 lines (+855/-273) (has conflicts)38 files modifieddatabase/schema/security.cfg (+1/-0)
lib/canonical/launchpad/doc/security-teams.txt (+2/-1)
lib/canonical/launchpad/mail/commands.py (+1/-1)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+8/-8)
lib/lp/bugs/browser/bug.py (+18/-9)
lib/lp/bugs/browser/bugtarget.py (+10/-1)
lib/lp/bugs/configure.zcml (+1/-0)
lib/lp/bugs/doc/bug-heat.txt (+22/-0)
lib/lp/bugs/doc/bug.txt (+1/-1)
lib/lp/bugs/doc/bugnotification-email.txt (+3/-3)
lib/lp/bugs/doc/bugnotification-sending.txt (+2/-1)
lib/lp/bugs/interfaces/bug.py (+12/-1)
lib/lp/bugs/model/bug.py (+27/-0)
lib/lp/bugs/scripts/bugheat.py (+1/-0)
lib/lp/bugs/scripts/bugimport.py (+1/-1)
lib/lp/bugs/scripts/tests/test_bugheat.py (+2/-2)
lib/lp/bugs/tests/test_bugchanges.py (+2/-2)
lib/lp/code/browser/branch.py (+13/-14)
lib/lp/code/configure.zcml (+2/-1)
lib/lp/code/errors.py (+23/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+3/-0)
lib/lp/code/interfaces/codeimport.py (+29/-1)
lib/lp/code/interfaces/webservice.py (+11/-0)
lib/lp/code/model/branchmergeproposal.py (+11/-10)
lib/lp/code/model/branchtarget.py (+20/-0)
lib/lp/code/model/codeimport.py (+24/-0)
lib/lp/code/model/tests/test_branchmergeproposals.py (+39/-0)
lib/lp/code/model/tests/test_codeimport.py (+67/-0)
lib/lp/code/stories/webservice/xx-code-import.txt (+368/-168)
lib/lp/services/worlddata/doc/language.txt (+33/-1)
lib/lp/services/worlddata/interfaces/language.py (+3/-2)
lib/lp/services/worlddata/tests/test_doc.py (+12/-1)
lib/lp/services/worlddata/tests/test_language.py (+21/-0)
lib/lp/soyuz/doc/archive.txt (+2/-2)
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+43/-9)
lib/lp/soyuz/model/archive.py (+1/-1)
lib/lp/soyuz/model/queue.py (+6/-3)
lib/lp/translations/templates/language-index.pt (+10/-29)
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| tags: | added: code-review confusing-ui |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: merge-queues |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-code: | |
| assignee: | nobody → Robert Collins (lifeless) |
| milestone: | none → 10.05 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Oh, and its marked readonly, so one can't set this by the API.