EmailAddressAlreadyTaken when logging in with an email address that's associated with a different OpenID identifier
Bug #556594 reported by
Guilherme Salgado
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Guilherme Salgado |
Bug Description
As seen on OOPS-1556K2375, the user tried to login but LP didn't have that identifier registered so it tried to create a new Account/
I'm tempted to just change the identifier associated with the registered email address to match the one given by the OP, but we should first confirm that no RPs are using these identifiers instead of the human-readable ones (https:/
Related branches
lp:~salgado/launchpad/bug-556594
Merged
into
lp:launchpad
- Francis J. Lacoste (community): Approve (release-critical)
- Brad Crittenden (community): Approve (code)
-
Diff: 228 lines (+94/-35)5 files modifiedlib/canonical/launchpad/database/account.py (+0/-4)
lib/canonical/launchpad/webapp/login.py (+41/-11)
lib/canonical/launchpad/webapp/tests/test_login.py (+44/-2)
lib/lp/registry/doc/person-account.txt (+5/-16)
lib/lp/testing/factory.py (+4/-2)
affects: | blueprint → launchpad-foundations |
Changed in launchpad-foundations: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
We cannot confirm that RPs have used these identifiers. That is information that the OP has, not us.
And in the end, we don't really care. We trust the OP, so if the OP comes back and says that the user has identifier XXYYZZ and that their email address is <email address hidden>, we should:
a) create an account for that identifier, if it doesn't exist
b) create the <email address hidden> email address, if it doesn't exist
But if the email address already exist, we should simply link the account to the person record owning the email address.