Circular import in some cases when importing from lp.registry.interfaces.person

[William Grant]

lp.registry.interfaces.person appears to have circular import issues at times. These imports are sufficient to cause the following traceback:

====
import _pythonpath

import functools

from zope.component import getUtility

from canonical.config import config
from lp.registry.interfaces.person import IPersonSet
====

====
Traceback (most recent call last):
  File "cronscripts/parse-ppa-apache-access-logs.py", line 17, in <module>
    from lp.registry.interfaces.person import IPersonSet
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/lp/registry/interfaces/person.py", line 71, in <module>
    from canonical.launchpad.interfaces.account import AccountStatus, IAccount
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/canonical/launchpad/interfaces/__init__.py", line 12, in <module>
    from lp.bugs.interfaces.malone import *
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/lp/bugs/interfaces/malone.py", line 12, in <module>
    from lp.bugs.interfaces.bug import IBug
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/lp/bugs/interfaces/bug.py", line 41, in <module>
    from lp.bugs.interfaces.bugbranch import IBugBranch
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/lp/bugs/interfaces/bugbranch.py", line 26, in <module>
    from lp.code.interfaces.branch import IBranch
  File "/home/wgrant/launchpad/checkouts/export-basic-binary-download-stats/lib/lp/code/interfaces/branch.py", line 76, in <module>
    from lp.registry.interfaces.person import IPerson
ImportError: cannot import name IPerson
====

[Curtis Hovey (sinzui)]

I started a branch to remove the glob imports, but it will take many weeks to get this landed. All circular imports will be fixed when all all modules stop using the globs. This requires landing fixes to shipit and canoical-identify provider first, then update all launchpad call sites. The fourth step is not mechanical, I expect that somce modules must be broken up as I remove the globs from the __init__.py

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11895 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11895>.

[Henning Eggers (henninge)]

Need to keep this branch from being deployed until I can talk to a losa about the qastaging breakage.