Launchpad itself

Need helpful error message when REFERER heading is missing

Bug #538236 reported by Sam_
44
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gary Poster
Launchpad itself 10.03

Bug Description

Without information, people can't know how to address the fact that we require REFERER headers.

See original description

Related branches

lp:~gary/launchpad/bug538236
Gary Poster (community): Abstain
Deryck Hodge (community): Approve (release-critical)
Michael Nelson (community): Approve (ui)
Guilherme Salgado (community): Approve
Diff: 194 lines (+79/-12)
6 files modified
lib/canonical/launchpad/pagetests/standalone/xx-offsite-form-post.txt (+32/-8)
lib/canonical/launchpad/templates/launchpad-noreferrer.pt (+26/-0)
lib/canonical/launchpad/webapp/error.py (+5/-0)
lib/canonical/launchpad/webapp/interfaces.py (+4/-0)
lib/canonical/launchpad/webapp/publication.py (+3/-4)
lib/canonical/launchpad/zcml/launchpad.zcml (+9/-0)
Revision history for this message
Sam_ (and-sam) wrote :

Removed uploaded screenshots and instead attached them.

Revision history for this message
Sam_ (and-sam) wrote :
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote : Re: UnexpectedFormData submitting answers comment

I need to wait for the oops report to be sent to investigate this--I need the oops id to locate what was sent and not sent.

summary: - Failure to submit comment, answer.
+ UnexpectedFormData submitting answers comment
Changed in launchpad-answers:
status: New → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

This bug is really a dup of another bug regarding form posts that are missing a referer. I'll need to track that bug to see if this one is automatically fixed.

Gary Poster (gary)
affects: launchpad-answers → launchpad-foundations
Changed in launchpad-foundations:
importance: Undecided → High
status: Incomplete → Triaged
Revision history for this message
Gary Poster (gary) wrote :

As Curtis says, I believe the reason that you were having problems is that your browser was configured to not send REFERER headers.

The underlying bug that we need to fix is that Launchpad should have let you know that this was the problem. I'm changing the bug to reflect this.

summary: - UnexpectedFormData submitting answers comment
+ UnexpectedFormData does not show helpful error messages
description: updated
Gary Poster (gary)
Changed in launchpad-foundations:
milestone: none → 10.03
Revision history for this message
Sam_ (and-sam) wrote : Re: UnexpectedFormData does not show helpful error messages

Thanks again for the helping hand, I'm allowing now referer to launchpad.
For the record:
the screenshot of error message when attempting to reply to bug report, which is different from replying to answers.

Revision history for this message
Gary Poster (gary) wrote :

Added https://answers.edge.launchpad.net/launchpad/+faq/1024 to answer the question. Maybe will link to this in the error message.

Changed in launchpad-foundations:
assignee: nobody → Gary Poster (gary)
Revision history for this message
Zooko Wilcox-O'Hearn (zooko) wrote :

Thanks, Gary. I'm experimenting with https://addons.mozilla.org/en-US/firefox/addon/86093 .

Gary Poster (gary)
summary: - UnexpectedFormData does not show helpful error messages
+ Need helpful error message when REFERER heading is missing
Gary Poster (gary)
description: updated
Gary Poster (gary)
Changed in launchpad-foundations:
status: Triaged → Fix Committed
Revision history for this message
Gary Poster (gary) wrote :

Attaching screenshot of proposed error page for UI review.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10606 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10606>

tags: added: qa-needstesting
Gary Poster (gary)
tags: added: qa-ok
removed: qa-needstesting
Gary Poster (gary)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.