Translation templates build gets wrong branch URL

Bug #537866 reported by Jeroen T. Vermeulen on 2010-03-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Jeroen T. Vermeulen

Bug Description

wgrant noticed that TranslationTemplatesBuildBehavior.dispatchBuildToSlave re-computes the branch_url argument passed to the slave, using IBranch.url instead of IBranch.composePublicURL which was specifically created for this.

To fix this, it would be enough to pass the TranslationTemplatesBuildJob's metadata to the slave as arguments, instead of re-computing them.

Related branches

Jeroen T. Vermeulen (jtv) wrote :

Shamelessly lumping in an unrelated issue: TranslationTemplatesBuildBehavior should override verifySlaveBuildID to accept the type of id strings generated by TranslationTemplatesBuildJob.getName.

Of the base verifySlaveBuildID, the part that checks the BuildQueue is generically useful so that should probably become a helper.

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
tags: added: qa-ok
removed: qa-needstesting
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers