Launchpad itself

Translation templates build gets wrong branch URL

Bug #537866 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 10.03

Bug Description

wgrant noticed that TranslationTemplatesBuildBehavior.dispatchBuildToSlave re-computes the branch_url argument passed to the slave, using IBranch.url instead of IBranch.composePublicURL which was specifically created for this.

To fix this, it would be enough to pass the TranslationTemplatesBuildJob's metadata to the slave as arguments, instead of re-computing them.

Related branches

lp:~jtv/launchpad/bug-537866
Guilherme Salgado (community): Approve
Diff: 695 lines (+372/-77)
9 files modified
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+1/-1)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+94/-10)
lib/lp/buildmaster/tests/test_buildfarmjobbehavior.py (+80/-8)
lib/lp/code/model/recipebuilder.py (+11/-2)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+4/-3)
lib/lp/testing/factory.py (+87/-40)
lib/lp/translations/doc/translationtemplatesbuildbehavior.txt (+41/-12)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+17/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+37/-0)
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Shamelessly lumping in an unrelated issue: TranslationTemplatesBuildBehavior should override verifySlaveBuildID to accept the type of id strings generated by TranslationTemplatesBuildJob.getName.

Of the base verifySlaveBuildID, the part that checks the BuildQueue is generically useful so that should probably become a helper.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10514 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10514>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.