Not all pluralforms displayed on language page
Bug #531831 reported by
Henning Eggers
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Данило Шеган |
Bug Description
See for example https:/
It says that the language has three plural forms but only lists examples for two.
See https:/
Arabic has 6 plural forms but only 5 are listed.
It looks like the code is failing to check for "zero" which you can see easily when looking at the Arabic plural expression:
n==0 ? 0 : n==1 ? 1 : ...
Related branches
lp:~danilo/launchpad/bug-531831
- Henning Eggers (community): Approve (code)
-
Diff: 131 lines (+74/-5)5 files modifiedlib/lp/translations/browser/tests/language-views.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-language.txt (+1/-1)
lib/lp/translations/utilities/doc/pluralforms.txt (+1/-1)
lib/lp/translations/utilities/pluralforms.py (+12/-2)
lib/lp/translations/utilities/tests/test_pluralforms.py (+59/-0)
Changed in rosetta: | |
importance: | Undecided → Low |
status: | New → In Progress |
assignee: | nobody → Данило Шеган (danilo) |
milestone: | none → 10.03 |
tags: | added: trivial ui |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Danilo, while you're at it: I think that file needs an __all__ as well!
(And in principle it might be good to let the example lists grow one item larger than the maximum number of examples we're going to display, so we know whether a "..." at the end is really justified. But I don't know if there are any languages with forms that occur for exactly 6 numbers in the sample range. :-)