Bug heat flames should be calculated based on the context, not the bugtask's target
Bug #531443 reported by
Eleanor Berger
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Eleanor Berger |
Bug Description
The current implementation of bugtask_heat_html uses the bugtask's target to find the maximum heat value to use. The problem is that in searches over a distribution or a project, the bugtask's target is not the context, and that produces odd results. The fix is to use the current context as the source for maximum heat.
Related branches
lp:~intellectronica/launchpad/max-heat-from-context
- Francis J. Lacoste (community): Approve (release-critical)
- Abel Deuring (community): Approve (code)
-
Diff: 1084 lines (+426/-78)24 files modifiedlib/canonical/launchpad/security.py (+3/-9)
lib/lp/bugs/browser/bugtask.py (+26/-9)
lib/lp/bugs/browser/tests/bug-heat-view.txt (+27/-2)
lib/lp/bugs/browser/tests/test_bugtarget_patches_view.py (+102/-0)
lib/lp/bugs/interfaces/bug.py (+7/-3)
lib/lp/bugs/stories/webservice/xx-bug.txt (+33/-0)
lib/lp/buildmaster/interfaces/buildbase.py (+4/-1)
lib/lp/buildmaster/manager.py (+5/-5)
lib/lp/buildmaster/master.py (+1/-1)
lib/lp/buildmaster/model/buildbase.py (+11/-8)
lib/lp/buildmaster/model/builder.py (+3/-3)
lib/lp/registry/model/distributionsourcepackage.py (+1/-0)
lib/lp/registry/stories/distribution/xx-distribution-packages.txt (+16/-2)
lib/lp/soyuz/browser/archivesubscription.py (+20/-6)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+6/-4)
lib/lp/soyuz/model/buildqueue.py (+10/-4)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt (+31/-8)
lib/lp/soyuz/stories/soyuz/xx-person-packages.txt (+22/-0)
lib/lp/soyuz/tests/test_buildqueue.py (+24/-8)
lib/lp/translations/browser/tests/language-views.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-language.txt (+1/-1)
lib/lp/translations/utilities/doc/pluralforms.txt (+1/-1)
lib/lp/translations/utilities/pluralforms.py (+12/-2)
lib/lp/translations/utilities/tests/test_pluralforms.py (+59/-0)
Changed in malone: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: story-bug-heat |
Changed in malone: | |
assignee: | nobody → Tom Berger (intellectronica) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in malone: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10463 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 10463>