Should use the mainsite's root URL as the openid.realm
Bug #530738 reported by
Guilherme Salgado
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Guilherme Salgado | ||
Bug Description
When sending a user to authenticate on the OpenID provider, we should use the mainsite's root URL instead of the application's URL (as we do currently). That's because the realm is "designed to give the end user an indication of the scope of the authentication request" and in our case the realm is really launchpad.net for any of our vhosts.
Related branches
lp:~salgado/launchpad/bug-530738
- Francis J. Lacoste (community): Approve (release-critical)
- Brad Crittenden (community): Approve (code)
-
Diff: 58 lines (+27/-3)2 files modifiedlib/canonical/launchpad/webapp/login.py (+2/-3)
lib/canonical/launchpad/webapp/tests/test_login.py (+25/-0)
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in devel r10427 <http://