Diff is never generated for merge proposal

[Andrew Bennetts]

I just looked at <https://code.edge.launchpad.net/~nmb/bzr/mkdir-recursive-253529/+merge/19488>. Despite being proposed for almost two weeks, Launchpad still claimed it was "Updating diff... An updated diff will be available in a few minutes. Reload to see the changes." I asked on #launchpad, and thumper said:

14:33 < thumper> spiv: because lp:~nmb/bzr/mkdir-recursive-253529 doesn't exist yet

Indeed, <https://code.edge.launchpad.net/~nmb/bzr/mkdir-recursive-253529> says "This branch has not been pushed to yet."

In this case the merge proposal page should not say "Updating diff...", which is clearly false. It should instead say what the actual status is, "No diff, because branch has not been pushed yet." or something even stronger.

I'd be tempted to go further and either reject this merge proposal from being submitted in the first place, or at least not include it in the +activereviews queue (so long as the proposer gets a notification that it is not active). This would automate what has to happen anyway: a human reviewer noticing the problem, rejecting the merge, and telling the proposer why.

WORK AROUND

Asl a webops on #launchpad-dev or #launchpad-ops to unscan the proposed branch.