Option to always tick "Someone should review this translation"

Bug #525992 reported by Adi Roiban on 2010-02-22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Adi Roiban

Bug Description

Member of translations teams are double agents and this is not an easy job :)

They can act as translators or as reviewers .... but if they try to act as humble translators LP just makes their life miserable as they will always have to check the "Someone should review this translation" checkbox.

Maybe we can add an option for "reviewers" to allow them to tell LP they are in "translators mode" and all "Someone should review this translation" checkboxes should be checked by default.

This can be done on clientside using a cookie and javascript.

The checkbox should be checked by default, but the reviewer could manually uncheck it.

Related branches

Adi Roiban (adiroiban) on 2010-02-22
Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
David Planella (dpm) wrote :

I've also always thought these would be a useful feature, but I had never figured out how this could be implemented. This is just a comment to say that I also think it's a good idea :)

This would definitely be a nice thing to have, but:
 * there is no natural place for such things yet (the best place is your dashboard at https://translations.launchpad.net/people/+me/), and it would not be preserved across different sessions/computers
 * I hate adding more complexity to +translate page when I'd rather have us rework it in a manner that Henning has started ~8 months ago

Still, I won't oppose adding it, as long as you understand that it may get lost in any refactoring of the +translate page, and that it will need reimplementing then.

Changed in rosetta:
status: New → Triaged
importance: Undecided → Low
tags: added: feature
Adi Roiban (adiroiban) wrote :

I don't know how other persons are using LP. I'm using LP translations for doing translations and reviewing.
Most of the time, my session on LP is a mixed one and having to go to +me page each time I need to change my „hat” can become an annoyance.

I was thinking at a footer link, similar to „Disable edge redirect”.

I don't know how do you plan to redesign the +translate page, but maybe in the new design we can have a switch to change the +translate mode page from translations to reviews ... or have a different +review view.

Adi Roiban (adiroiban) wrote :
Adi Roiban (adiroiban) wrote :

Totally undiscoverable there!

How about we add some JS instead: when you click on the checkbox for the first time, it can ask you something like: "Do you want all your submissions to be reviewed by default for this template translations?"

If you answer "Yes", it would basically set a per-template cookie that would make JS check all 'needs review' boxes for you automatically (on page load). Now, since these would be per-template, they could use short-lived cookies (session-based, or eg. less than 3h, whatever you prefer: I tend to have very long running sessions myself :), so there'd be no need to allow an option to revert a default.

If you answer "No", it'll just store the answer in a similar cookie and won't ask you again on that template when you click on needs-review check box.

Btw, part of what +translate page redesign and refactoring will do is split translator and reviewer modes.

Adi Roiban (adiroiban) wrote :
Adi Roiban (adiroiban) wrote :
Adi Roiban (adiroiban) on 2010-04-14
Changed in rosetta:
status: Triaged → In Progress
Milo Casagrande (milo) wrote :

Just to have an idea of how the "set all as need review" will work, what will happen if there are already translated strings in the page, and I check the "set all as need review" flag?

Adi Roiban (adiroiban) wrote :

Hi Milo,

In the proposed solution there is not such thing as „Set all as need review”.
There is only an option to switch between „Reviewer” and „Translator” mode.

When you are in „translator” mode, all your new translations will be automatically marked as „someone needs to review it”.

„Review” mode is the working mode that you know it right now :)

This branch should land on edge in a couple of hours.

Changed in rosetta:
milestone: none → 10.05
status: In Progress → Fix Committed
tags: added: qa-needstesting
Adi Roiban (adiroiban) on 2010-05-24
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui) on 2010-06-02
Changed in rosetta:
status: Fix Committed → Fix Released
André Gondim (andregondim) wrote :

I don't see nothing different between these views..

Cheers. ;)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers