add Unlink button to $sourcepackage/+edit-packaging form
Bug #525956 reported by
Edwin Grubbs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs | ||
Bug Description
Although a user can set the upstream link for a sourcepackage on the sourcepackage page, it is only possible to remove the link on the distrosourcepackage page, which is not obvious. The $sourcepackage/
The results can be confusing though, because the model's SourcePackage class' productseries attribute will try to find a productseries from a previous sourcepackage. This will be displayed on the sourcepackage index page, but it is not explained how this default is determined.
Related branches
lp:~edwin-grubbs/launchpad/bug-525956-unlink-button
- Curtis Hovey (community): Approve (code + ui)
- Eleanor Berger (community): Approve (code ui*)
-
Diff: 1398 lines (+373/-417)26 files modifiedlib/canonical/launchpad/icing/style-3-0.css.in (+1/-1)
lib/canonical/launchpad/templates/launchpad-form.pt (+7/-0)
lib/canonical/launchpad/webapp/launchpadform.py (+31/-3)
lib/lp/registry/browser/configure.zcml (+16/-0)
lib/lp/registry/browser/distributionsourcepackage.py (+1/-22)
lib/lp/registry/browser/packaging.py (+0/-96)
lib/lp/registry/browser/product.py (+11/-48)
lib/lp/registry/browser/sourcepackage.py (+48/-15)
lib/lp/registry/browser/tests/packaging-views.txt (+41/-46)
lib/lp/registry/browser/tests/sourcepackage-views.txt (+52/-6)
lib/lp/registry/browser/tests/test_packaging.py (+4/-2)
lib/lp/registry/model/productseries.py (+4/-2)
lib/lp/registry/model/sourcepackage.py (+5/-4)
lib/lp/registry/stories/distroseries/xx-show-distroseries-packaging.txt (+5/-4)
lib/lp/registry/stories/packaging/xx-distributionsourcepackage-packaging-concurrent-deletion.txt (+9/-14)
lib/lp/registry/stories/packaging/xx-distributionsourcepackage-packaging.txt (+10/-6)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+1/-3)
lib/lp/registry/stories/product/xx-product-package-pages.txt (+11/-8)
lib/lp/registry/stories/productseries/xx-productseries-delete.txt (+4/-2)
lib/lp/registry/templates/distributionsourcepackage-index.pt (+3/-29)
lib/lp/registry/templates/distroseries-packaging.pt (+2/-37)
lib/lp/registry/templates/product-packages.pt (+8/-19)
lib/lp/registry/templates/sourcepackage-portlet-associations.pt (+1/-47)
lib/lp/registry/templates/sourcepackage-remove-packaging.pt (+34/-0)
lib/lp/registry/templates/sourcepackage-upstream-connections.pt (+63/-0)
lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt (+1/-3)
| Changed in launchpad-registry: | |
| milestone: | none → 10.02 |
| Changed in launchpad-registry: | |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| status: | In Progress → Triaged |
| Changed in launchpad-registry: | |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| milestone: | 10.02 → 10.03 |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 525956 Fix released | #2 |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10445 <http://