createMergeProposal under-documented and unfriendly API

Bug #520106 reported by James Westby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

createMergeProposal takes a reviewers argument and a review_types argument,
but neither explain what they do. (prerequisite_branch and target_branch are also
under-documented, but they are more ovbious).

In addition, you have to pass a list to review_types if you pass one to reviewers,
but I think it would be nice if you didn't have to and if it got None it just assumed
[""] * len(reviewers).

Thanks,

James

Tags: api lp-code
Revision history for this message
James Westby (james-w) wrote :

Oh, and

  API-oriented version of addLandingTarget.

  The parameters are the same as addLandingTarget, except that
  review_requests is split into a list of reviewers and a list of review types.

isn't very useful external documentation as addLandingTarget is not
exposed.

Thanks,

James

Tim Penhey (thumper)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
tags: added: api
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.