Librarian returns 200 with error as the content when a file is missing from disk
Bug #51370 reported by
Stuart Bishop
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
William Grant | ||
Bug Description
If the Librarian tries to serve a file that exists in the database, but not on the filesystem, a suitable HTTP error code should be returned such as 404 or a resource unavailable. At the moment, a 200 response is returned containing an HTML error message.
See test_layers.py for reproduction - there is an XXX in that file.
One implementation would be to raise an OOPS and return a 404 to the user. Or a 50x.
| Changed in launchpad: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| Changed in launchpad-foundations: | |
| status: | Confirmed → Triaged |
| Changed in launchpad-foundations: | |
| importance: | Low → Medium |
| visibility: | private → public |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad-foundations: | |
| status: | Triaged → Incomplete |
Revision history for this message
| Stuart Bishop (stub) wrote | #2 |
| Changed in launchpad-foundations: | |
| status: | Incomplete → Fix Committed |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| importance: | Medium → High |
| description: | updated |
| summary: |
- Librarian should return an error if file on disk not found + Librarian returns 200 with error as the content when a file is missing + from disk |
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug would be helped by a reproduction recipe.