BuildBase says it implements IBuildBase, but does not
Bug #510919 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Nelson | ||
Bug Description
At the moment, the following test fails.
def test_build_
# XXX: BuildBase is supposed to implement IBuildBase, but doesn't atm.
# Since it's not the focus of the branch, we'll postpone the work.
build_base = BuildBase()
(from lib/lp/
Related branches
lp:~michael.nelson/launchpad/create-source-recipe-build2
- Muharem Hrnjadovic (community): Approve
-
Diff: 501 lines (+180/-37)12 files modifiedlib/lp/archiveuploader/permission.py (+19/-10)
lib/lp/archiveuploader/tests/test_permission.py (+8/-0)
lib/lp/buildmaster/interfaces/buildbase.py (+1/-1)
lib/lp/buildmaster/model/buildbase.py (+9/-5)
lib/lp/buildmaster/tests/test_buildbase.py (+0/-8)
lib/lp/soyuz/interfaces/sourcepackagerecipe.py (+12/-0)
lib/lp/soyuz/model/build.py (+4/-9)
lib/lp/soyuz/model/sourcepackagerecipe.py (+29/-0)
lib/lp/soyuz/model/sourcepackagerecipebuild.py (+2/-1)
lib/lp/soyuz/tests/test_build.py (+24/-1)
lib/lp/soyuz/tests/test_sourcepackagerecipe.py (+67/-0)
lib/lp/soyuz/tests/test_sourcepackagerecipebuild.py (+5/-2)
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #1 |
| Changed in soyuz: | |
| assignee: | nobody → Michael Nelson (michael.nelson) |
| milestone: | none → 10.02 |
| status: | Triaged → In Progress |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #2 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
From the branch:
Note: this class does not implement IBuildBase as we currently duplicate the properties defined on IBuildBase on the inheriting class tables. BuildBase cannot therefore implement IBuildBase itself, as storm requires that the corresponding __storm_table__ be defined for the class. Instead, the classes using the BuildBase mixin must ensure that they implement IBuildBase.