Plural messages reported as having new suggestions while no new suggestions are displayed
Bug #509080 reported by
Adi Roiban
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
Launcpad is reporting there are new suggestions for this po file, but I can not see them:
Any idea where are the new suggestions or why is this po file reported as having 3 new suggestions?
Changed in launchpad: | |
status: | Triaged → Fix Released |
To post a comment you must log in.
Indeed, and this is what we have in the DB:
lpmain_staging=> select translationmess age.id, translationmess age.is_ imported, translationmess age.msgstr0, translationmess age.msgstr1, translationmess age.msgstr2, translationmess age.date_ created, translationmess age.date_ reviewed from translationmessage join language on language= language. id where potmsgset=8159727 and language.code='ro'; ----+-- ------- ----+-- ------- -+----- ----+-- ------- -+----- ------- ------- ------- --+---- ------- ------- ------- ---
id | is_imported | msgstr0 | msgstr1 | msgstr2 | date_created | date_reviewed
-------
182435604 | t | 15639594 | 7843906 | 16656767 | 2007-09-23 14:24:44.753061 | 2007-10-30 08:25:11.396216
66965158 | f | 7843905 | 7843906 | | 2006-12-02 23:27:17.589556 | 2006-12-02 23:27:17.589556
109089390 | f | 15639594 | | | 2008-01-15 11:33:27.231931 |
So, the "new" suggestion is the one from 2009-01-15, but it has the same translation for plural form 0, and no translations for other plural forms (i.e. empty translations). Because of the way we display plural forms (i.e. suggestions are per-form, instead of per-entire message), we normalize out these messages in the UI display code. Basically, the only "new" suggestions that should be displayed are empty suggestions for the two latter plural forms. Perhaps we can instead show these, though we would have to check what will we break (i.e. why do we hide these otherwise).
What we should do is change the display of these messages, which is something Henning started on a while ago, but we never got it completed.
At the moment, this is a very low priority bug since I can't imagine this bug to appear very often.
Work-around: submit a new suggestion and then dismiss it.