Upload buildfarm-generated templates
Bug #507680 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Henning Eggers |
Bug Description
Once a bunch of templates have been generated from a branch and retrieved from the slave (bug 507678), a script needs to upload it to any productseries that wants its templates automatically generated from that branch.
Related branches
lp:~henninge/launchpad/bug-507680-upload-templates
Merged
into
lp:launchpad
- Jeroen T. Vermeulen (community): Approve (code)
-
Diff: 929 lines (+432/-120)14 files modifiedlib/canonical/buildd/generate-translation-templates (+4/-1)
lib/canonical/buildd/pottery/generate_translation_templates.py (+24/-9)
lib/canonical/buildd/template-buildd-slave.conf (+1/-0)
lib/canonical/buildd/tests/test_generate_translation_templates.py (+27/-4)
lib/canonical/buildd/tests/test_translationtemplatesbuildmanager.py (+4/-1)
lib/canonical/buildd/translationtemplates.py (+16/-1)
lib/lp/code/interfaces/branchjob.py (+0/-14)
lib/lp/code/model/branchjob.py (+6/-16)
lib/lp/registry/doc/productseries.txt (+19/-53)
lib/lp/registry/interfaces/productseries.py (+14/-0)
lib/lp/registry/model/productseries.py (+12/-0)
lib/lp/registry/tests/test_productseries.py (+220/-0)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+10/-2)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+75/-19)
tags: | added: wellington |
Changed in rosetta: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in rosetta: | |
status: | Triaged → In Progress |
assignee: | nobody → Henning Eggers (henninge) |
milestone: | none → 10.03 |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The upload needs to be done by the master, of course (the slave has no access to the database). The code to do this should slot into TranslationTemp latesBuildBehav ior._uploadTarb all (look for the XXX with this bug's number).
As per our discussions yesterday, the chosen approach is for this code to pass the tarball straight to ITranslationImp ortQueue. addOrUpdateEntr iesFromTarball, passing a new parameter that will tell it that the upload embodies the complete set of templates. With that information in hand, addOrUpdateEntr iesFromTarball can approve instantly.