Launchpad itself

merge team can fail if a team has an email address

Bug #506965 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs
Launchpad itself 10.01

Bug Description

AdminMergeBaseView.doMerge() oopes when the team has an email address. The email address may not be visible because when a team removes it, it was hidden, not deleted.

The method does use removeSecurityProxy, but does this after the attempt the set the status. The call to removeSecurityProxy should be moved before the call to set the status.

Related branches

lp:~edwin-grubbs/launchpad/bug-506965-merge-team-oops
Curtis Hovey (community): Approve
Diff: 246 lines (+82/-43)
4 files modified
lib/lp/registry/browser/menu.py (+1/-1)
lib/lp/registry/browser/peoplemerge.py (+4/-4)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+34/-4)
lib/lp/registry/stories/team/xx-adminteammerge.txt (+43/-34)
Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
Edwin Grubbs (edwin-grubbs)
summary: - Delete team can fail if a team has an email address
+ merge team can fail if a team has an email address
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.