ValueError while validating image file using Python Imaging Lib

[Diogo Matsubara]

We use the Python Imaging Library to identify the image type uploaded on the +edithackergotchi page.
Usually when the PIL can't identify an image type, it raises a IOError, but it might raise a "ValueError: cannot read this XPM file" when uploading a broken XPM file. When that happens we see OOPS-171A222, OOPS-379D69, OOPS-1595L2717

The same applies when you try to upload a team emblem through +editemblem or a icon for your product using +branding

[Diogo Matsubara (matsubara)]

<SteveA> matsubara: for 50616, I think we should try-except, and such images should be rejected as invalid
<salgado> agreed. that's what I had in mind
<SteveA> but we should also record the fact they were rejected, and the image involved
<SteveA> just in this case, not in the general case

[Carlos Perelló Marín (carlos)]

This bug also affects product creation: OOPS-402B296

[Curtis Hovey (sinzui)]

The error message handling was changed after this was reported. The message we have is good for both IOError and ValueError, we just need to catch ValueError too.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12345 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12345>.